Bug 233515 - GraphicsContextGLANGLE.cpp has platform specific code
Summary: GraphicsContextGLANGLE.cpp has platform specific code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: gcgranglecleanup 233589
  Show dependency tree / graph
 
Reported: 2021-11-26 00:25 PST by Kimmo Kinnunen
Modified: 2021-11-29 12:51 PST (History)
14 users (show)

See Also:

Attachments
Patch (9.63 KB, patch)
2021-11-26 00:30 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (14.93 KB, patch)
2021-11-26 03:27 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (23.27 KB, patch)
2021-11-26 05:19 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (23.27 KB, patch)
2021-11-26 05:24 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (23.38 KB, patch)
2021-11-26 05:53 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (23.38 KB, patch)
2021-11-26 05:58 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-11-26 00:25:45 PST 
GraphicsContextGLANGLE.cpp has platform specific code

This should be invoked through virtual functions and the code should be moved to the platform specific implementations
This way platform specific implementation like GraphicsContextGLOpenGL Cocoa flavour can be in future be called GraphicsContextGLCocoa, since GraphicsContextGLOpenGL and GraphicsContextGLANGLE would be also separate classes.
Comment 1 Kimmo Kinnunen 2021-11-26 00:30:35 PST 
Created attachment 445175 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-11-26 03:27:56 PST 
Created attachment 445186 [details]
Patch
Comment 3 Kimmo Kinnunen 2021-11-26 05:19:18 PST 
Created attachment 445190 [details]
Patch
Comment 4 Kimmo Kinnunen 2021-11-26 05:24:15 PST 
Created attachment 445191 [details]
Patch
Comment 5 Kimmo Kinnunen 2021-11-26 05:53:35 PST 
Created attachment 445195 [details]
Patch
Comment 6 Kimmo Kinnunen 2021-11-26 05:58:21 PST 
Created attachment 445196 [details]
Patch
Comment 7 EWS 2021-11-29 01:41:26 PST 
Committed r286205 (244587@main): <https://commits.webkit.org/244587@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445196 [details].
Comment 8 Radar WebKit Bug Importer 2021-11-29 01:42:22 PST 
<rdar://problem/85803889>
Comment 9 Fujii Hironori 2021-11-29 12:51:05 PST 
This change broke WinCairo WebGL tests.
Filed: Bug 233589 – REGRESSION(r286205) [WinCairo] WebGL tests are failing