Bug 233566 - Make support for WebKitAdditions in Framework headers conditional based on deployment target
Summary: Make support for WebKitAdditions in Framework headers conditional based on de...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 233374
Blocks: 233569
  Show dependency treegraph
 
Reported: 2021-11-29 09:33 PST by Chris Dumez
Modified: 2021-11-29 11:58 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.59 KB, patch)
2021-11-29 09:34 PST, Chris Dumez
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-11-29 09:33:02 PST
Make support for WebKitAdditions in Framework headers conditional based on deployment target.
Comment 1 Chris Dumez 2021-11-29 09:34:26 PST
Created attachment 445285 [details]
Patch
Comment 2 Wenson Hsieh 2021-11-29 11:17:47 PST
Comment on attachment 445285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445285&action=review

> Source/WebKit/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

While the change is pretty self-explanatory, I think a brief sentence here enumerating the supported OS versions might still be helpful.
Comment 3 Chris Dumez 2021-11-29 11:57:25 PST
Committed r286250 (244613@main): <https://commits.webkit.org/244613@main>
Comment 4 Radar WebKit Bug Importer 2021-11-29 11:58:28 PST
<rdar://problem/85828458>