Bug 233374 - Revert r282446 to bring back support for WebKitAdditions in Framework headers
Summary: Revert r282446 to bring back support for WebKitAdditions in Framework headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 233566
  Show dependency treegraph
 
Reported: 2021-11-19 10:59 PST by Chris Dumez
Modified: 2021-11-29 09:33 PST (History)
4 users (show)

See Also:


Attachments
Patch (7.07 KB, patch)
2021-11-19 11:02 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (7.13 KB, patch)
2021-11-19 12:53 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-11-19 10:59:25 PST
Revert r282446 to bring back support for WebKitAdditions in Framework headers.
Comment 1 Chris Dumez 2021-11-19 11:02:03 PST
Created attachment 444837 [details]
Patch
Comment 2 Wenson Hsieh 2021-11-19 12:26:39 PST
Comment on attachment 444837 [details]
Patch

r=me to revert the revert!

It does seem like our Python linter rules have changed in the meantime though, so it would be nice to address `check-webkit-style` errors before landing.
Comment 3 Chris Dumez 2021-11-19 12:53:16 PST
Created attachment 444846 [details]
Patch
Comment 4 EWS 2021-11-19 14:38:08 PST
Committed r286080 (244467@main): <https://commits.webkit.org/244467@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444846 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-19 14:39:21 PST
<rdar://problem/85620173>