This is a step towards simplifying the FilterEffect geometry and removing the FilterImage from FilterEffect.
Created attachment 445169 [details] Patch
Comment on attachment 445169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445169&action=review > Source/WebCore/ChangeLog:11 > + getting the moved the absolutePaintRect of a FilterEffect. No need for "getting the moved absolutePaintRect"? > Source/WebCore/ChangeLog:12 > + clamping scaling since all FilterImages have to be within MaxClampedArea. "clamping or scaling" > Source/WebCore/platform/graphics/filters/FilterImage.cpp:60 > +IntRect FilterImage::relativeAbsoluteImageRect(const FilterImage& origin) const "relativeAbsoluteImageRect" is a confusing name for me, since "relative" and "absolute" are opposites. I'm struggling to come up with a good name -- something like "absoluteImageRectRelativeToFilterImage"? Not sure. Maybe there could be a better name if the "this" and argument were the other way around?
Created attachment 445170 [details] Patch
Comment on attachment 445169 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445169&action=review >> Source/WebCore/platform/graphics/filters/FilterImage.cpp:60 >> +IntRect FilterImage::relativeAbsoluteImageRect(const FilterImage& origin) const > > "relativeAbsoluteImageRect" is a confusing name for me, since "relative" and "absolute" are opposites. I'm struggling to come up with a good name -- something like "absoluteImageRectRelativeToFilterImage"? Not sure. Maybe there could be a better name if the "this" and argument were the other way around? We agreed on naming it absoluteImageRectRelativeTo() at least for now.
Committed r286172 (244555@main): <https://commits.webkit.org/244555@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445170 [details].
<rdar://problem/85761241>