Bug 233500 - Remove the code under #if HAVE(ARM_NEON_INTRINSICS)
Summary: Remove the code under #if HAVE(ARM_NEON_INTRINSICS)
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 231253
  Show dependency tree / graph
 
Reported: 2021-11-25 13:21 PST by Said Abou-Hallawa
Modified: 2022-02-10 16:18 PST (History)
19 users (show)

See Also:

Attachments
Patch (94.99 KB, patch)
2021-11-25 13:28 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Patch (96.21 KB, patch)
2021-11-25 15:11 PST, Said Abou-Hallawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2021-11-25 13:21:42 PST 
The sources and headers under platform/graphics/cpu/arm/ do not compile anymore.

1. The file platform/graphics/cpu/arm/filters/FEBlendNEON.h won't compile because it references FilterEffect::pixelBufferResult() which does not exist anymore.
2. The file platform/graphics/cpu/arm/filters/FELightingNEON.cpp won't compile because it references FELighting:LightingData which does not exist anymore.
Comment 1 Said Abou-Hallawa 2021-11-25 13:28:51 PST 
Created attachment 445153 [details]
Patch
Comment 2 Said Abou-Hallawa 2021-11-25 15:11:27 PST 
Created attachment 445158 [details]
Patch
Comment 3 Said Abou-Hallawa 2021-11-25 23:27:33 PST 
These header files were not referenced in the code:

platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h
platform/graphics/cpu/arm/filters/FEGaussianBlurNEON.h
Comment 4 Radar WebKit Bug Importer 2021-12-02 13:22:21 PST 
<rdar://problem/85986173>
Comment 5 Said Abou-Hallawa 2022-01-25 14:23:17 PST 
Bug 235410 is the opposite of this bug. It tries to get the code under  HAVE(ARM_NEON_INTRINSICS) be compiled. So close this one for now. My understanding is a new bot for armv7 might be added to WebKit build system soon.