Bug 233446 - [selectors] Import 2 new :focus-visible tests from WPT
Summary: [selectors] Import 2 new :focus-visible tests from WPT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords: InRadar
Depends on:
Blocks: 221925
  Show dependency tree / graph
 
Reported: 2021-11-23 07:14 PST by Manuel Rego Casasnovas
Modified: 2021-11-25 00:47 PST (History)
5 users (show)

See Also:

Attachments
Patch (23.51 KB, patch)
2021-11-23 07:15 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch (23.55 KB, patch)
2021-11-24 01:18 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch (24.69 KB, patch)
2021-11-24 02:19 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2021-11-23 07:14:50 PST 
[selectors] Import 2 new :focus-visible tests from WPT
Comment 1 Manuel Rego Casasnovas 2021-11-23 07:15:20 PST 
Created attachment 445029 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2021-11-24 01:14:50 PST 
The timeouts we're seeing clicking on the image are due to bug #233470.

I'll tweak the test to avoid the timeout.
Comment 3 Manuel Rego Casasnovas 2021-11-24 01:18:19 PST 
Created attachment 445081 [details]
Patch
Comment 4 Manuel Rego Casasnovas 2021-11-24 02:19:35 PST 
Created attachment 445083 [details]
Patch
Comment 5 Antti Koivisto 2021-11-24 05:12:47 PST 
Comment on attachment 445083 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445083&action=review

> LayoutTests/imported/w3c/ChangeLog:8
> +        We're slightly tweaking the tests due to bug webkit.org/b/233470.

Are you also updating the tweaks to WPT? We shouldn't be out of sync.
Comment 6 Manuel Rego Casasnovas 2021-11-24 05:39:31 PST 
(In reply to Antti Koivisto from comment #5)
> Comment on attachment 445083 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=445083&action=review
> 
> > LayoutTests/imported/w3c/ChangeLog:8
> > +        We're slightly tweaking the tests due to bug webkit.org/b/233470.
> 
> Are you also updating the tweaks to WPT? We shouldn't be out of sync.

Yes, that's in the "See also" field: https://github.com/web-platform-tests/wpt/pull/31728

With the r+ here, it got automatically approved there, and I already merged it in WPT.

Now let's land this in WebKit via cq.
Comment 7 EWS 2021-11-24 05:41:08 PST 
Committed r286146 (244530@main): <https://commits.webkit.org/244530@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445083 [details].
Comment 8 Radar WebKit Bug Importer 2021-11-24 05:42:20 PST 
<rdar://problem/85726464>