RESOLVED FIXED 221925
[selectors] Use :focus-visible in the user agent style sheet 
https://bugs.webkit.org/show_bug.cgi?id=221925
Summary [selectors] Use :focus-visible in the user agent style sheet
Manuel Rego Casasnovas
Reported 2021-02-15 14:17:09 PST
Once :focus-visible is implemented we should change the default style sheet to use it instead of :-webkit-direct-focus. Ideally it should keep the same behavior than :-webkit-direct-focus once the following CSSWG issue is resolved: https://github.com/w3c/csswg-drafts/issues/5893#issuecomment-771230873 Otherwise we'll need to think about what we should do here. Selectors and HTML specs indicate this: * https://drafts.csswg.org/selectors-4/#the-focus-visible-pseudo * https://html.spec.whatwg.org/multipage/rendering.html#phrasing-content-3 Chromium and Firefox already do this.
Attachments
Patch (1.16 KB, patch)
2021-11-09 04:45 PST, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
for bots (1.03 KB, patch)
2021-11-10 02:00 PST, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
for bots (1.03 KB, patch)
2021-11-25 00:48 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
NOT FOR LANDING: Patch for bots (1.17 KB, patch)
2021-12-02 02:15 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
Patch (13.98 KB, patch)
2021-12-09 03:35 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-02-22 14:18:14 PST
<rdar://problem/74613552>
Manuel Rego Casasnovas
Comment 2 2021-03-03 00:33:36 PST
Once we do this, we'll probably want to add a similar optimization to the one we have for :focus in RuleSet and ElementRuleCollector. This was part of a previous patch but wasn't merged yet as it was not needed from the functionality POV, see comments at https://bugs.webkit.org/show_bug.cgi?id=222028 for more details: * https://bugs.webkit.org/show_bug.cgi?id=222028#c39 * https://bugs.webkit.org/show_bug.cgi?id=222028#c42 * https://bugs.webkit.org/show_bug.cgi?id=222028#c44
Antti Koivisto
Comment 3 2021-11-09 04:45:02 PST
Created attachment 443680 [details] Patch
Antti Koivisto
Comment 4 2021-11-10 02:00:11 PST
Created attachment 443786 [details] for bots
Antti Koivisto
Comment 5 2021-11-25 00:48:39 PST
Created attachment 445123 [details] for bots
Manuel Rego Casasnovas
Comment 6 2021-12-02 02:15:39 PST
Created attachment 445696 [details] NOT FOR LANDING: Patch for bots
Antti Koivisto
Comment 7 2021-12-09 03:35:04 PST
Created attachment 446515 [details] Patch
Manuel Rego Casasnovas
Comment 8 2021-12-09 04:26:10 PST
Comment on attachment 446515 [details] Patch r=me
EWS
Comment 9 2021-12-09 05:15:43 PST
Committed r286775 (245016@main): <https://commits.webkit.org/245016@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446515 [details].
Brent Fulgham
Comment 10 2022-02-04 12:43:07 PST
This change should be present in STP 139, iOS 15.4 Beta, and macOS 12.3 Beta.
Note You need to log in before you can comment on or make changes to this bug.