Bug 233416 - [WASM-GC] Add support for GC structs types encoding
Summary: [WASM-GC] Add support for GC structs types encoding
Status: RESOLVED DUPLICATE of bug 263026
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dmitry
URL:
Keywords: InRadar
Depends on:
Blocks: 247394 246981
  Show dependency treegraph
 
Reported: 2021-11-22 02:18 PST by Dmitry
Modified: 2024-07-24 15:16 PDT (History)
10 users (show)

See Also:


Attachments
Patch (47.75 KB, patch)
2021-11-22 02:21 PST, Dmitry
no flags Details | Formatted Diff | Diff
Patch (47.80 KB, patch)
2021-11-22 02:26 PST, Dmitry
no flags Details | Formatted Diff | Diff
Patch (70.95 KB, patch)
2021-12-07 02:05 PST, Dmitry
no flags Details | Formatted Diff | Diff
Patch (95.56 KB, patch)
2021-12-07 02:36 PST, Dmitry
no flags Details | Formatted Diff | Diff
Patch (70.95 KB, patch)
2021-12-07 02:38 PST, Dmitry
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry 2021-11-22 02:18:39 PST
Wasm GC proposal introduces struct types in the MVP: https://github.com/WebAssembly/gc/blob/master/proposals/gc/MVP.md.
So, this is a first step to support them - support encoding scheme.
Comment 1 Dmitry 2021-11-22 02:21:15 PST
Created attachment 444952 [details]
Patch
Comment 2 EWS Watchlist 2021-11-22 02:22:07 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Comment 3 Dmitry 2021-11-22 02:26:12 PST
Created attachment 444953 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2021-11-29 02:19:24 PST
<rdar://problem/85804675>
Comment 5 Dmitry 2021-12-07 02:05:12 PST
Created attachment 446138 [details]
Patch
Comment 6 Dmitry 2021-12-07 02:36:15 PST
Created attachment 446145 [details]
Patch
Comment 7 Dmitry 2021-12-07 02:38:11 PST
Created attachment 446146 [details]
Patch
Comment 8 Asumu Takikawa 2024-02-06 12:10:19 PST
I think we can likely close this bug now
Comment 9 David Degazio 2024-07-24 15:16:10 PDT
Yeah this looks pretty closable, we have had handling for WASM GC types and opcodes for months. Resolving as a dupe of https://bugs.webkit.org/show_bug.cgi?id=263026.

*** This bug has been marked as a duplicate of bug 263026 ***