Bug 233248 - AX: Use ObjectIdentifier for AXID
Summary: AX: Use ObjectIdentifier for AXID
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 233260
Blocks:
  Show dependency treegraph
 
Reported: 2021-11-17 02:58 PST by Carlos Garcia Campos
Modified: 2021-11-18 01:51 PST (History)
12 users (show)

See Also:


Attachments
Patch (22.88 KB, patch)
2021-11-17 03:00 PST, Carlos Garcia Campos
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (23.55 KB, patch)
2021-11-17 03:45 PST, Carlos Garcia Campos
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (27.37 KB, patch)
2021-11-17 05:08 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Patch for landing (27.37 KB, patch)
2021-11-18 00:49 PST, Carlos Garcia Campos
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (29.34 KB, patch)
2021-11-18 01:11 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-11-17 02:58:19 PST
Use ObjectIdentifier for AXID.
Comment 1 Radar WebKit Bug Importer 2021-11-17 02:58:48 PST
<rdar://problem/85497145>
Comment 2 Carlos Garcia Campos 2021-11-17 03:00:05 PST
Created attachment 444503 [details]
Patch
Comment 3 Carlos Garcia Campos 2021-11-17 03:45:55 PST
Created attachment 444505 [details]
Patch
Comment 4 Carlos Garcia Campos 2021-11-17 05:08:10 PST
Created attachment 444509 [details]
Patch
Comment 5 Tyler Wilcock 2021-11-17 08:13:59 PST
I re-ran the tests with this patch and the results look good to me for Clang + Mac.

(re-posting https://bugs.webkit.org/show_bug.cgi?id=233004#c5)

My main is currently at revision: https://github.com/WebKit/WebKit/commit/ce9ed8749594cb74cb8b154c56c91a8fe0bac858

Main: 161 text failures, 3 crashes, 8 timeouts
Main + patch https://bugs.webkit.org/attachment.cgi?id=444509&action=prettypatch: 160 text failures, 2 crashes, 9 timeouts
Comment 6 EWS 2021-11-17 10:14:34 PST
Committed r285934 (244343@main): <https://commits.webkit.org/244343@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444509 [details].
Comment 7 WebKit Commit Bot 2021-11-17 10:25:37 PST
Re-opened since this is blocked by bug 233260
Comment 8 Carlos Garcia Campos 2021-11-18 00:49:44 PST
Created attachment 444645 [details]
Patch for landing
Comment 9 Carlos Garcia Campos 2021-11-18 01:11:33 PST
Created attachment 444647 [details]
Patch for landing
Comment 10 Carlos Garcia Campos 2021-11-18 01:51:52 PST
Committed r285991 (244388@main): <https://commits.webkit.org/244388@main>