Bug 233004 – AX: Add missing AXID variant to AXPropertyValueVariant

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

In this method:

void AXIsolatedObject::setObjectProperty(AXPropertyName propertyName, AXCoreObject* object)
{
    if (object)
        setProperty(propertyName, object->objectID());
    else
        setProperty(propertyName, nullptr, true);
}

We set properties with AXID values. However, there is no AXID variant in AXPropertyValueVariant, so none of these property lookups ever returned values.

[Radar WebKit Bug Importer]

<rdar://problem/85305185>

[Tyler Wilcock]

Created attachment 443970 [details]
Patch

[EWS]

Committed r285686 (244161@main): <https://commits.webkit.org/244161@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443970 [details].

[Carlos Garcia Campos]

hmm, this broke the build here with isolated tree enabled, I don't know if it's because of GCC:

Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:482:51: error: cannot convert ‘WebCore::AXID’ {aka ‘long unsigned int’} to ‘WebCore::AXPropertyValueVariant&&’ {aka ‘std::variant<std::nullptr_t, long unsigned int, WTF::String, bool, int, unsigned int, double, float, long unsigned int, WebCore::Color, WTF::URL, WebCore::LayoutRect, WebCore::FloatRect, PAL::SessionID, WebCore::IntPoint, WTF::OptionSet<WebCore::SpeakAs>, std::pair<unsigned int, unsigned int>, WTF::Vector<WebCore::AccessibilityText, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<long unsigned int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<std::pair<long unsigned int, long unsigned int>, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<WTF::String, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WebCore::Path, WTF::OptionSet<WebCore::AXAncestorFlag> >&&’}
  482 |         setProperty(propertyName, object->objectID());
      |                                   ~~~~~~~~~~~~~~~~^~
      |                                                   |
      |                                                   WebCore::AXID {aka long unsigned int}

Maybe the problem is that we now have long unsigned int twice AXID and uint64_t.

[Tyler Wilcock]

Sorry for causing more GTK breakage, Carlos. Indeed, it must be a difference in the way GCC and Clang handle size_t in this case. Just to reconfirm the results of this patch with Clang + Mac, I ran the tests one more time (run-webkit-tests --no-retry --release --accessibility-isolated-tree accessibility/):

My main is currently at revision: https://github.com/WebKit/WebKit/commit/ce9ed8749594cb74cb8b154c56c91a8fe0bac858

Main with r285686: 161 text failures, 3 crashes, 8 timeouts
Main without r285686: 197 text failures, 1 crash, 11 timeouts

I also ran the tests with your latest AXID ObjectIdentifier patch (https://bugs.webkit.org/attachment.cgi?id=444509&action=prettypatch) + main and got: 160 text failures, 2 crashes, 9 timeouts

Which seems good to me. Thanks for fixing this in https://bugs.webkit.org/show_bug.cgi?id=233248!