Bug 233186 - Add support for rvfc to MediaPlayerPrivateMediaSourceAVFObjC
Summary: Add support for rvfc to MediaPlayerPrivateMediaSourceAVFObjC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 231945
Blocks: 211945 233306
  Show dependency treegraph
 
Reported: 2021-11-16 04:34 PST by youenn fablet
Modified: 2021-12-03 08:04 PST (History)
9 users (show)

See Also:


Attachments
Patch (9.93 KB, patch)
2021-11-16 07:35 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (11.66 KB, patch)
2021-11-18 08:00 PST, youenn fablet
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (11.75 KB, patch)
2021-11-18 08:07 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-11-16 04:34:12 PST
Add support for rvfc to MediaPlayerPrivateMediaSourceAVFObjC
Comment 1 youenn fablet 2021-11-16 07:35:42 PST
Created attachment 444378 [details]
Patch
Comment 2 youenn fablet 2021-11-18 08:00:41 PST
Created attachment 444676 [details]
Patch
Comment 3 youenn fablet 2021-11-18 08:07:10 PST
Created attachment 444677 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2021-11-23 04:35:23 PST
<rdar://problem/85699161>
Comment 5 youenn fablet 2021-11-30 01:31:03 PST
Ping review
Comment 6 EWS 2021-11-30 10:15:54 PST
Committed r286305 (244664@main): <https://commits.webkit.org/244664@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444677 [details].
Comment 7 Philippe Normand 2021-11-30 10:48:02 PST
Comment on attachment 444677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444677&action=review

> Source/WebCore/ChangeLog:11
> +        We only enable the test if mediaSourceInlinePaintingEnabled is true since canvas painting does not work otherwise.

on ports enabling the GPUProcess or on all ports?
Comment 8 youenn fablet 2021-12-01 00:33:07 PST
Comment on attachment 444677 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444677&action=review

>> Source/WebCore/ChangeLog:11
>> +        We only enable the test if mediaSourceInlinePaintingEnabled is true since canvas painting does not work otherwise.
> 
> on ports enabling the GPUProcess or on all ports?

On Cocoa ports enabling GPUProcess only.
You might want to tweak InternalSettings::mediaSourceInlinePaintingEnabled() or the test itself for GTK/WPE ports once you have rvfc support.
Comment 9 Philippe Normand 2021-12-03 08:04:57 PST
https://bugs.webkit.org/show_bug.cgi?id=233813