AX: Simplify tests changed in https://bugs.webkit.org/show_bug.cgi?id=233085

[Tyler Wilcock]

In https://bugs.webkit.org/show_bug.cgi?id=233085 and https://bugs.webkit.org/show_bug.cgi?id=233017, we made some tests async so that they passed in --release --accessibility-isolated-tree mode. However, we can make these tests simpler and still pass — i.e., only wait for elements and expressions asynchronously when it's absolutely necessary.

[Radar WebKit Bug Importer]

<rdar://problem/85441015>

[Tyler Wilcock]

Created attachment 444337 [details]
Patch

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #2)
> Created attachment 444337 [details]
> Patch

--- a/LayoutTests/accessibility/mac/header.html
+++ a/LayoutTests/accessibility/mac/header.html

+    function expectRole(expectedRole, expectedDescription, id) {
+        shouldBeEqualToString(`accessibilityController.accessibleElementById("${id}").role`, "AXRole: " + expectedRole);
+        shouldBeEqualToString(`accessibilityController.accessibleElementById("${id}").roleDescription`, "AXRoleDescription: " + expectedDescription);

Can we do `AXRole: ${expectedRole}` and `AXRoleDescription: ${expectedDescription}` in the second params of the shouldBes?

[Tyler Wilcock]

Created attachment 444376 [details]
Patch

[EWS]

Committed r285874 (244300@main): <https://commits.webkit.org/244300@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444376 [details].