Bug 233017 - AX: Make accessibility/mac/header.html test async to fix it for isolated tree mode
Summary: AX: Make accessibility/mac/header.html test async to fix it for isolated tree...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-11 14:52 PST by Tyler Wilcock
Modified: 2021-11-15 20:48 PST (History)
10 users (show)

See Also:

Attachments
Patch (4.47 KB, patch)
2021-11-11 15:00 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (9.31 KB, patch)
2021-11-11 22:06 PST, Tyler Wilcock 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.45 KB, patch)
2021-11-11 22:30 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (11.21 KB, patch)
2021-11-12 06:52 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2021-11-11 14:52:31 PST 
Make accessibility/mac/header.html test async to fix it for isolated tree mode
Comment 1 Radar WebKit Bug Importer 2021-11-11 14:52:47 PST 
<rdar://problem/85316962>
Comment 2 Tyler Wilcock 2021-11-11 15:00:15 PST 
Created attachment 444007 [details]
Patch
Comment 3 Tyler Wilcock 2021-11-11 22:06:49 PST 
Created attachment 444046 [details]
Patch
Comment 4 Tyler Wilcock 2021-11-11 22:30:33 PST 
Created attachment 444047 [details]
Patch
Comment 5 Tyler Wilcock 2021-11-12 06:52:38 PST 
Created attachment 444062 [details]
Patch
Comment 6 EWS 2021-11-13 10:38:19 PST 
Committed r285776 (244220@main): <https://commits.webkit.org/244220@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444062 [details].
Comment 7 Andres Gonzalez 2021-11-15 11:09:51 PST 
(In reply to Tyler Wilcock from comment #5)
> Created attachment 444062 [details]
> Patch

Should we revisit this change after discussion on https://bugs.webkit.org/show_bug.cgi?id=233085?

No need to wait here or make async, since instead of setting the focus, we can get the accessible element by id.
Comment 8 Tyler Wilcock 2021-11-15 20:48:49 PST 
(In reply to Andres Gonzalez from comment #7)
> (In reply to Tyler Wilcock from comment #5)
> > Created attachment 444062 [details]
> > Patch
> 
> Should we revisit this change after discussion on
> https://bugs.webkit.org/show_bug.cgi?id=233085?
> 
> No need to wait here or make async, since instead of setting the focus, we
> can get the accessible element by id.
Yep! Addressing in: https://bugs.webkit.org/show_bug.cgi?id=233167