How to reproduce:
- Launch MiniBrowser on the target
- Launch MiniBrowser on the host (WinCairo)
- Try to connect to the target by inspector://.
- The target should be listed.
- "No targets found" message is shown.
This issue is same as bug 226908. r277787 changed WebURLSchemeTask::request()'s return type and caused the issue.
Created attachment 443918 [details]
Patch to fix the issue in the same way as r278748.
Committed r285641 (244142@main): <https://commits.webkit.org/244142@main>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 443918 [details].
Comment on attachment 443918 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=443918&action=review
> + Remote Inspector has the same issue as bug 226908.
> + RemoteInspectorProtocolHandler needs the same fix as r278748.
I haven't seen that patch at the time, but I don't see how either of the fixes is correct. Could you please clarify?
(In reply to Alexey Proskuryakov from comment #4)
> Comment on attachment 443918 [details]
> View in context:
> > Source/WebKit/ChangeLog:9
> > + Remote Inspector has the same issue as bug 226908.
> > + RemoteInspectorProtocolHandler needs the same fix as r278748.
> I haven't seen that patch at the time, but I don't see how either of the
> fixes is correct. Could you please clarify?
Sure, sorry for not explaining in this bugzilla.
(quoted from bug 226908 comment 1)
> r277787 (Bug 226001) changed the return type of
> from const WebCore::ResourceRequest& to WebCore::ResourceRequest.
> InspectorResourceURLSchemeHandler::platformStartTask shouldn't
> hold the reference of temporary object.
Currently, task.request() creates a temporal ResourceRequest, which is destructed immediately after "auto& requestURL = task.request().url();".
ResourceRequest.url() returns the reference of ResourceRequest.m_url, so it's also destructed immediately too.
Therefore requestURL becomes a invalid reference to destructed object, which should not be happened. (In this case, it's recognized as null URL.)
So we changed "auto&" to "auto" to copy the temporal URL.