Bug 226908 – [WinCairo] Can't open WebInspector UI since r277787

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Fujii Hironori]

[WinCairo][WK2] Can't open WebInspector UI since r277787

1. Start WinCairo WK2 MiniBrowser
2. Menu -> Develop -> Show Web Inspector

Extected: Web Inspector appears.
Actual: Nothing appears.

r277787 (Bug 226001) changed the return type of WebURLSchemeTask::request() 
from const WebCore::ResourceRequest& to WebCore::ResourceRequest.

InspectorResourceURLSchemeHandler::platformStartTask shouldn't
hold the reference of temporary object.

[Fujii Hironori]

Created attachment 431164 [details]
WIP patch

[Fujii Hironori]

Created attachment 431165 [details]
Patch

[Fujii Hironori]

Comment on attachment 431165 [details]
Patch

Clearing flags on attachment: 431165

Committed r278748 (238709@main): <https://commits.webkit.org/238709@main>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/79174706>

[Alexey Proskuryakov]

Comment on attachment 431165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431165&action=review

> Source/WebKit/ChangeLog:13
> +        InspectorResourceURLSchemeHandler::platformStartTask shouldn't
> +        hold the reference of the temporary object.

What is the problem with that? Is it a bug in the compiler that you use?

[Fujii Hironori]

Comment on attachment 431165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431165&action=review

>> Source/WebKit/ChangeLog:13
>> +        hold the reference of the temporary object.
> 
> What is the problem with that? Is it a bug in the compiler that you use?

This is not a compiler issue.
task.request() returns a ResourceRequest object.
task.request().url() returns a URL of it.
However, the ResourceRequest object is destructed on the end of the line.

[Alexey Proskuryakov]

I see, so it's ResourceRequest that is the temporary object, not the URL. Makes sense.