Bug 226908 - [WinCairo] Can't open WebInspector UI since r277787
Summary: [WinCairo] Can't open WebInspector UI since r277787
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-10 18:10 PDT by Fujii Hironori
Modified: 2021-06-16 03:24 PDT (History)
7 users (show)

See Also:


Attachments
WIP patch (750 bytes, patch)
2021-06-10 18:21 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
Patch (1.90 KB, patch)
2021-06-10 18:35 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-06-10 18:10:25 PDT
[WinCairo][WK2] Can't open WebInspector UI since r277787

1. Start WinCairo WK2 MiniBrowser
2. Menu -> Develop -> Show Web Inspector

Extected: Web Inspector appears.
Actual: Nothing appears.

r277787 (Bug 226001) changed the return type of WebURLSchemeTask::request() 
from const WebCore::ResourceRequest& to WebCore::ResourceRequest.

InspectorResourceURLSchemeHandler::platformStartTask shouldn't
hold the reference of temporary object.
Comment 1 Fujii Hironori 2021-06-10 18:21:02 PDT
Created attachment 431164 [details]
WIP patch
Comment 2 Fujii Hironori 2021-06-10 18:35:12 PDT
Created attachment 431165 [details]
Patch
Comment 3 Fujii Hironori 2021-06-10 19:36:49 PDT
Comment on attachment 431165 [details]
Patch

Clearing flags on attachment: 431165

Committed r278748 (238709@main): <https://commits.webkit.org/238709@main>
Comment 4 Fujii Hironori 2021-06-10 19:36:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2021-06-10 19:37:18 PDT
<rdar://problem/79174706>