Bug 232905 - Upstream: Fix occlusion query buffer synchronization in angle end2end tests
Summary: Upstream: Fix occlusion query buffer synchronization in angle end2end tests
Status: RESOLVED DUPLICATE of bug 220896
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kyle Piddington
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-09 14:12 PST by Kyle Piddington
Modified: 2022-01-19 11:15 PST (History)
6 users (show)

See Also:


Attachments
Patch (4.46 KB, patch)
2021-11-09 14:13 PST, Kyle Piddington
kkinnunen: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle Piddington 2021-11-09 14:12:29 PST
Upstream: Fix occlusion query buffer synchronization in angle end2end tests
Comment 1 Kyle Piddington 2021-11-09 14:13:10 PST
Created attachment 443727 [details]
Patch
Comment 2 EWS Watchlist 2021-11-09 14:14:11 PST
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kimmo Kinnunen 2021-11-10 09:12:06 PST
Comment on attachment 443727 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443727&action=review

looks good with the nits fixed

> Source/ThirdParty/ANGLE/ChangeLog:6
> +	Ensure that GPU synchronization is flushed before

ChangeLog needs a certain format, these need the tabs

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_resources.h:91
> +         // encoded on the GPU, and a map operation must wait

comment lines don't align
Comment 4 Radar WebKit Bug Importer 2021-11-16 14:13:18 PST
<rdar://problem/85474799>
Comment 5 Kyle Piddington 2022-01-19 11:15:21 PST
Fixed in 
Roll ANGLE to include upstreamed Metal backend
https://bugs.webkit.org/show_bug.cgi?id=220896
<rdar://problem/73539682>

*** This bug has been marked as a duplicate of bug 220896 ***