This will eliminate the branching we do in CSSFilter::apply(). This will also remove the classes FilterEffectRenderer and FilterEffectRendererCoreImage.
<rdar://problem/85424049>
Created attachment 445211 [details] Patch
Comment on attachment 445211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445211&action=review > Source/WebCore/platform/graphics/coreimage/FEColorMatrixCoreImageApplier.mm:3 > +/* > +* Copyright (C) 2020-2021 Apple Inc. All rights reserved. > +* This (and in the other added files in this patch) is copied from another file, but the asterisks are misaligned. > Source/WebCore/svg/graphics/filters/SVGFilter.cpp:91 > +bool SVGFilter::supportsCoreImageRendering() const > +{ I notice that this and CSSFIlter::supportsCoreImageRendering() are very similar, and that CSSFilter::m_functions and SVGFilter::m_expression are almost the same type. Should we have a common implementation of supportsCoreImageRendering() on Filter (or maybe you will move some CSSFilter and SVGFilter commonality up to Filter in a later patch in your queue)?
Created attachment 445229 [details] Patch
Comment on attachment 445211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445211&action=review >> Source/WebCore/platform/graphics/coreimage/FEColorMatrixCoreImageApplier.mm:3 >> +* > > This (and in the other added files in this patch) is copied from another file, but the asterisks are misaligned. Fixed. >> Source/WebCore/svg/graphics/filters/SVGFilter.cpp:91 >> +{ > > I notice that this and CSSFIlter::supportsCoreImageRendering() are very similar, and that CSSFilter::m_functions and SVGFilter::m_expression are almost the same type. Should we have a common implementation of supportsCoreImageRendering() on Filter (or maybe you will move some CSSFilter and SVGFilter commonality up to Filter in a later patch in your queue)? Yes this similarities in CSSFilter and SVGFilter should be removed once the result FilterImage is removed from FilterEffect.
Committed r286193 (244575@main): <https://commits.webkit.org/244575@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445229 [details].