Bug 23283 - Optimize RenderBox::localToAbsoluteQuad() to use LayoutState
Summary: Optimize RenderBox::localToAbsoluteQuad() to use LayoutState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on: 24163
Blocks:
  Show dependency tree / graph
 
Reported: 2009-01-12 21:23 PST by Simon Fraser (smfr)
Modified: 2009-03-12 11:26 PDT (History)
1 user (show)

See Also:

Attachments
Patch, changelog (1.46 KB, patch)
2009-01-12 21:30 PST, Simon Fraser (smfr) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2009-01-12 21:23:38 PST 
RenderBox::localToAbsoluteQuad() shows up in some profiles for deeply nested content. It should be fixed to use LayoutState when possible.
Comment 1 Simon Fraser (smfr) 2009-01-12 21:30:01 PST 
Created attachment 26660 [details]
Patch, changelog
Comment 2 Eric Seidel (no email) 2009-02-06 14:01:00 PST 
Comment on attachment 26660 [details]
Patch, changelog

This looks sane to me.  I can't promise I'm an expert in this code though.  You might yet want Hyatt or Mitz to look at this.  But as I said above, it looks right by my eyes.
Comment 3 Simon Fraser (smfr) 2009-03-12 11:26:57 PDT 
Got done as part of the patch in bug 24163.