Bug 232619 – perspective() <= 1px should be clamped to 1px

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Martin Robinson]

There are some relevant W3C issues for this:
 * https://github.com/w3c/csswg-drafts/issues/413
 * https://github.com/w3c/csswg-drafts/issues/6320
 * https://github.com/w3c/csswg-drafts/issues/6346

[Radar WebKit Bug Importer]

<rdar://problem/85197362>

[Martin Robinson]

Created attachment 445729 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 445729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445729&action=review

> Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h:68
> +        return m_interoperabilityState == TransformInteropabilityEnabled ? std::max(1.0f, returnValue) : returnValue;

Not sure if it's worth plumbing ScriptExecutionContext all the way through just to check the setting here. I bet we could do this without undue compat risk.

[Martin Robinson]

Created attachment 445848 [details]
Patch

[Martin Robinson]

Created attachment 446028 [details]
Patch

[Martin Robinson]

(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 445729 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=445729&action=review
> 
> > Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h:68
> > +        return m_interoperabilityState == TransformInteropabilityEnabled ? std::max(1.0f, returnValue) : returnValue;
> 
> Not sure if it's worth plumbing ScriptExecutionContext all the way through
> just to check the setting here. I bet we could do this without undue compat
> risk.


Thanks for the review. I've updated the patch to remove the plumbing and also updated the WebKit-specific tests that were failing.

[Martin Robinson]

Created attachment 446131 [details]
Patch

[EWS]

Committed r286591 (?): <https://commits.webkit.org/r286591>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446131 [details].