Bug 232619 - perspective() <= 1px should be clamped to 1px
Summary: perspective() <= 1px should be clamped to 1px
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: InRadar
Depends on: 232618
Blocks:
  Show dependency tree / graph
 
Reported: 2021-11-02 05:09 PDT by Martin Robinson
Modified: 2021-12-07 00:27 PST (History)
13 users (show)

See Also:

Attachments
Patch (32.66 KB, patch)
2021-12-02 09:45 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (34.97 KB, patch)
2021-12-03 07:20 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (23.33 KB, patch)
2021-12-06 05:11 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (23.32 KB, patch)
2021-12-06 23:36 PST, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Radar WebKit Bug Importer 2021-11-09 04:10:20 PST 
<rdar://problem/85197362>
Comment 2 Martin Robinson 2021-12-02 09:45:56 PST 
Created attachment 445729 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-12-02 10:42:17 PST 
Comment on attachment 445729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445729&action=review

> Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h:68
> +        return m_interoperabilityState == TransformInteropabilityEnabled ? std::max(1.0f, returnValue) : returnValue;

Not sure if it's worth plumbing ScriptExecutionContext all the way through just to check the setting here. I bet we could do this without undue compat risk.
Comment 4 Martin Robinson 2021-12-03 07:20:30 PST 
Created attachment 445848 [details]
Patch
Comment 5 Martin Robinson 2021-12-06 05:11:07 PST 
Created attachment 446028 [details]
Patch
Comment 6 Martin Robinson 2021-12-06 05:30:43 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 445729 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=445729&action=review
> 
> > Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h:68
> > +        return m_interoperabilityState == TransformInteropabilityEnabled ? std::max(1.0f, returnValue) : returnValue;
> 
> Not sure if it's worth plumbing ScriptExecutionContext all the way through
> just to check the setting here. I bet we could do this without undue compat
> risk.


Thanks for the review. I've updated the patch to remove the plumbing and also updated the WebKit-specific tests that were failing.
Comment 7 Martin Robinson 2021-12-06 23:36:02 PST 
Created attachment 446131 [details]
Patch
Comment 8 EWS 2021-12-07 00:27:19 PST 
Committed r286591 (?): <https://commits.webkit.org/r286591>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446131 [details].