Some aspects of the CSS Transforms Level 2 specification break backward compatibility. Having a runtime flag for this behavior will allowing experimenting with turning it on in order to test compatibility.
Created attachment 443325 [details] Patch
<rdar://problem/85196916>
Comment on attachment 443325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443325&action=review r- to switch to a setting. > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:1325 > + humanReadableDescription: "Enable Transforms Level 2 spec compliant behavior that is backwards incompatble" "incompatble". I think we can come up with a better name/description. Maybe "CSS 3D Transform Interoperability"? > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:1326 > + webcoreBinding: RuntimeEnabledFeatures We don't use RuntimeEnabledFeatures any more.
Created attachment 445409 [details] Patch
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 443325 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443325&action=review > > r- to switch to a setting. Thanks for the review! I've uploaded a new version of the change that addresses your comments. > > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:1325 > > + humanReadableDescription: "Enable Transforms Level 2 spec compliant behavior that is backwards incompatble" > > "incompatble". > > I think we can come up with a better name/description. Maybe "CSS 3D > Transform Interoperability"? I've improved the description and the naming along the lines you suggested. > > > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:1326 > > + webcoreBinding: RuntimeEnabledFeatures > > We don't use RuntimeEnabledFeatures any more. Ah, I wasn't aware of this! I've converted this to a setting. It will require piping things through a bit (since it seems that settings are accessed through the Document), but this isn't a bit deal.
Comment on attachment 445409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445409&action=review > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:170 > + humanReadableDescription: "Enable 3D transform behavior that specification-compliant but backwards incompatible" that is specification-compliant
Created attachment 445542 [details] Patch
Committed r286357 (244716@main): <https://commits.webkit.org/244716@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445542 [details].