Bug 232228 - [WPE][Qt] Do not use WebKit internals in the implementation
Summary: [WPE][Qt] Do not use WebKit internals in the implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-25 02:12 PDT by Adrian Perez
Modified: 2021-10-28 13:59 PDT (History)
11 users (show)

See Also:

Attachments
Patch (10.49 KB, patch)
2021-10-28 06:46 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Patch (10.46 KB, patch)
2021-10-28 12:20 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2021-10-25 02:12:19 PDT 
Currently the WPE Qt implementation still has a few uses of GRefPtr
and GUniquePtr. These are only a handful, and could be easily removed.
Doing this would allow packagers to split building of the Qt API away
from the rest of a WPE port build, in its own package, without needing
to rebuild all WebKit for something that is essentially a layer which
build on top of the public WPE port API.
Comment 1 Adrian Perez 2021-10-28 06:46:44 PDT 
Created attachment 442702 [details]
Patch
Comment 2 Adrian Perez 2021-10-28 12:20:22 PDT 
Created attachment 442729 [details]
Patch


Same patch as before, rebased after the fix for bug #232435 got landed
Comment 3 Michael Catanzaro 2021-10-28 12:38:37 PDT 
All looks good to me. I assume Phil will want to review it, though.
Comment 4 Adrian Perez 2021-10-28 13:33:58 PDT 
(In reply to Michael Catanzaro from comment #3)
> All looks good to me. I assume Phil will want to review it, though.

I had discussed with Philippe the possibility of making this patch
before submitting it, so I was indeed waiting for his review :)

Thanks to you both!
Comment 5 EWS 2021-10-28 13:58:06 PDT 
Committed r285000 (243646@main): <https://commits.webkit.org/243646@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442729 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-28 13:59:18 PDT 
<rdar://problem/84776484>