Bug 232435 - [WPE][Qt] String memory leak in WPEQtView.cpp
Summary: [WPE][Qt] String memory leak in WPEQtView.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-28 07:11 PDT by Adrian Perez
Modified: 2021-10-28 10:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2021-10-28 07:24 PDT, Adrian Perez 		don.olmstead: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2021-10-28 07:11:31 PDT 
In WPEQtView.cpp currently there is something like this, around line 435:

    variant.setValue(QString(g_strdup(strValue.get())));

Note that the pointer returned by g_strdup() is not freed, and the QString
constructor makes a copy of the string. Not only this makes one uneeded copy,
but also the one done by g_strdup() gets leaked.
Comment 1 Adrian Perez 2021-10-28 07:24:17 PDT 
Created attachment 442704 [details]
Patch
Comment 2 EWS 2021-10-28 09:04:56 PDT 
Committed r284983 (243630@main): <https://commits.webkit.org/243630@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442704 [details].
Comment 3 Radar WebKit Bug Importer 2021-10-28 09:05:29 PDT 
<rdar://problem/84759895>