Bug 232196 – Add support for fast-cq mode to webkit-patch land-safely command

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

We added fast-cq mode support to webkit-patch upload command in 236308@main. We should also add support for it in webkit-patch land-safely command.

[Aakash Jain]

fast-cq support for webkit-patch land-safely command was requested in https://lists.webkit.org/pipermail/webkit-dev/2021-October/032019.html

[Aakash Jain]

Created attachment 442257 [details]
Patch

[Aakash Jain]

Created attachment 442258 [details]
Patch

[John Wilander]

Thanks! This’ll be an excellent enhancement. Someone else should review the patch but it wasn’t clear to me that it updates the help documentation of webkit-patch. Does it? Maybe that’s generated somehow.

[Aakash Jain]

Help documentation is updated automatically.

e.g.:
[~]$ webkit-patch help land-safely
land-safely [options] [BUGID]   Land the current diff via the commit-queue

land-safely updates the ChangeLog with the reviewer listed
    in bugs.webkit.org for BUGID (or the bug ID detected from the ChangeLog).
    The command then uploads the current diff to the bug and marks it for
    commit by the commit-queue.

Options:
  --architecture=ARCHITECTURE
                        Target architecture
  --check-oops          Check there are no OOPS left in change log
  --fast-cq, --fast-commit-queue, --fastcq
                        Enable fast-commit-queue mode for this patch, that
                        skips building and testing.
...

[Aakash Jain]

Created attachment 442368 [details]
[fast-cq] Patch for landing

[EWS]

Committed r284783 (243492@main): <https://commits.webkit.org/243492@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442368 [details].

[Aakash Jain]

Landed this with following command: webkit-patch land-safely --fast-cq

[Radar WebKit Bug Importer]

<rdar://problem/84613190>