Bug 232196 - Add support for fast-cq mode to webkit-patch land-safely command
Summary: Add support for fast-cq mode to webkit-patch land-safely command
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-23 04:59 PDT by Aakash Jain
Modified: 2021-10-25 07:37 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.20 KB, patch)
2021-10-23 05:08 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Patch (3.82 KB, patch)
2021-10-23 05:22 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
[fast-cq] Patch for landing (3.81 KB, patch)
2021-10-25 07:34 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-10-23 04:59:25 PDT 
We added fast-cq mode support to webkit-patch upload command in 236308@main. We should also add support for it in webkit-patch land-safely command.
Comment 1 Aakash Jain 2021-10-23 05:01:32 PDT 
fast-cq support for webkit-patch land-safely command was requested in https://lists.webkit.org/pipermail/webkit-dev/2021-October/032019.html
Comment 2 Aakash Jain 2021-10-23 05:08:22 PDT 
Created attachment 442257 [details]
Patch
Comment 3 Aakash Jain 2021-10-23 05:22:54 PDT 
Created attachment 442258 [details]
Patch
Comment 4 John Wilander 2021-10-23 07:40:17 PDT 
Thanks! This’ll be an excellent enhancement. Someone else should review the patch but it wasn’t clear to me that it updates the help documentation of webkit-patch. Does it? Maybe that’s generated somehow.
Comment 5 Aakash Jain 2021-10-25 05:21:23 PDT 
Help documentation is updated automatically.

e.g.:
[~]$ webkit-patch help land-safely
land-safely [options] [BUGID]   Land the current diff via the commit-queue

land-safely updates the ChangeLog with the reviewer listed
    in bugs.webkit.org for BUGID (or the bug ID detected from the ChangeLog).
    The command then uploads the current diff to the bug and marks it for
    commit by the commit-queue.

Options:
  --architecture=ARCHITECTURE
                        Target architecture
  --check-oops          Check there are no OOPS left in change log
  --fast-cq, --fast-commit-queue, --fastcq
                        Enable fast-commit-queue mode for this patch, that
                        skips building and testing.
...
Comment 6 Aakash Jain 2021-10-25 07:34:43 PDT 
Created attachment 442368 [details]
[fast-cq] Patch for landing
Comment 7 EWS 2021-10-25 07:36:51 PDT 
Committed r284783 (243492@main): <https://commits.webkit.org/243492@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442368 [details].
Comment 8 Aakash Jain 2021-10-25 07:37:13 PDT 
Landed this with following command: webkit-patch land-safely --fast-cq
Comment 9 Radar WebKit Bug Importer 2021-10-25 07:37:45 PDT 
<rdar://problem/84613190>