Bug 224286 - Add webkit-patch support for fast-cq mode
Summary: Add webkit-patch support for fast-cq mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-07 09:18 PDT by Aakash Jain
Modified: 2021-04-08 13:03 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.02 KB, patch)
2021-04-07 09:21 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
[fast-cq] Patch (8.16 KB, patch)
2021-04-07 09:33 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-04-07 09:18:32 PDT
r275282 added fast-cq mode (for landing patches quickly through commit-queue by skipping building and testing). We should webkit-patch support for fast-cq mode.

webkit-patch should have a --fast-cq parameter, which would result in uploaded patch being appropriately named on Bugzilla to trigger fast-cq mode.
Comment 1 Aakash Jain 2021-04-07 09:21:17 PDT Comment hidden (obsolete)
Comment 2 Aakash Jain 2021-04-07 09:33:43 PDT
Created attachment 425411 [details]
[fast-cq] Patch
Comment 3 Alexey Proskuryakov 2021-04-07 09:44:18 PDT
This seems fine to do, but I don't really understand the goal. I understand that everything will be landed via commit queue on GitHub. But what exactly will we achieve by encouraging people to use CQ more now? Are you expecting that we'll still be using patch based workflow, so we need to find and fix all svn-apply bugs and limitations?
Comment 4 Aakash Jain 2021-04-07 11:20:00 PDT
(In reply to Alexey Proskuryakov from comment #3)
> This seems fine to do, but I don't really understand the goal. I understand
> that everything will be landed via commit queue on GitHub. But what exactly
> will we achieve by encouraging people to use CQ more now? Are you expecting
> that we'll still be using patch based workflow, so we need to find and fix
> all svn-apply bugs and limitations?
This comment seems more about Bug 223942.

fast commit queue mode would be useful even in git world, since there would be various scenarios in which people would want to land quickly or skip building/testing, e.g.: build fix, typo fix, minor follow-up fix. For example, I just used this --fast-cq parameter to upload a patch for small follow-up fix in https://bugs.webkit.org/show_bug.cgi?id=223686#c14.

I will discuss the concerns about Bug 223942 separately.
Comment 5 EWS 2021-04-08 13:02:59 PDT
Committed r275672 (236308@main): <https://commits.webkit.org/236308@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 425411 [details].
Comment 6 Radar WebKit Bug Importer 2021-04-08 13:03:34 PDT
<rdar://problem/76417274>