Bug 231645 - add test for bug 231353
Summary: add test for bug 231353
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on: 229025 231353
Blocks:
  Show dependency tree / graph
 
Reported: 2021-10-12 16:39 PDT by Cameron McCormack (:heycam)
Modified: 2021-10-23 01:19 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.56 KB, patch)
2021-10-12 16:41 PDT, Cameron McCormack (:heycam) 		youennf: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (3.59 KB, patch)
2021-10-19 01:42 PDT, Cameron McCormack (:heycam) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for EWS (3.58 KB, patch)
2021-10-22 18:22 PDT, Cameron McCormack (:heycam) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for EWS (3.59 KB, patch)
2021-10-22 23:26 PDT, Cameron McCormack (:heycam) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-10-12 16:39:03 PDT 
.
Comment 1 Radar WebKit Bug Importer 2021-10-12 16:40:04 PDT 
<rdar://problem/84172363>
Comment 2 Cameron McCormack (:heycam) 2021-10-12 16:41:37 PDT 
Created attachment 441018 [details]
Patch
Comment 3 Cameron McCormack (:heycam) 2021-10-12 16:41:55 PDT 
(That'll fail EWS since the dependencies haven't landed yet.)
Comment 4 youenn fablet 2021-10-13 11:06:23 PDT 
Comment on attachment 441018 [details]
Patch

r=me once bots are happy

View in context: https://bugs.webkit.org/attachment.cgi?id=441018&action=review

> LayoutTests/webrtc/captureStream-color-space.html:10
> +    let srcContext = src.getContext("2d");

Could use const I guess here and below.

> LayoutTests/webrtc/captureStream-color-space.html:28
> +    assert_array_approx_equals(actual, expected, 2, `actual = ${actual}, expected = ${expected}`);

If this fails, we probably never hit t.done().
Maybe 2 is too small.

> LayoutTests/webrtc/captureStream-color-space.html:32
> +var t = async_test(function(t) {

Could use async_test(async function...

> LayoutTests/webrtc/captureStream-color-space.html:45
> +    local.createOffer().then(function(desc) {

You could write it with await in a more readable way
Comment 5 Cameron McCormack (:heycam) 2021-10-13 21:11:04 PDT 
(In reply to youenn fablet from comment #4)
> > LayoutTests/webrtc/captureStream-color-space.html:28
> > +    assert_array_approx_equals(actual, expected, 2, `actual = ${actual}, expected = ${expected}`);
> 
> If this fails, we probably never hit t.done().

I think the test harness considers a test done when it catches an exception, and we are in a step_func() here.

> Maybe 2 is too small.

I want it to be just small enough that it passes.  We'll see if EWS is OK with it.
Comment 6 Cameron McCormack (:heycam) 2021-10-19 01:42:19 PDT 
Created attachment 441701 [details]
Patch for landing
Comment 7 Cameron McCormack (:heycam) 2021-10-22 18:22:41 PDT 
Created attachment 442238 [details]
Patch for EWS
Comment 8 Cameron McCormack (:heycam) 2021-10-22 23:26:13 PDT 
Created attachment 442254 [details]
Patch for EWS