Bug 231645 – add test for bug 231353

• Status: NEW
• Component: WebRTC

[Cameron McCormack (:heycam)]

.

[Radar WebKit Bug Importer]

<rdar://problem/84172363>

[Cameron McCormack (:heycam)]

Created attachment 441018 [details]
Patch

[Cameron McCormack (:heycam)]

(That'll fail EWS since the dependencies haven't landed yet.)

[youenn fablet]

Comment on attachment 441018 [details]
Patch

r=me once bots are happy

View in context: https://bugs.webkit.org/attachment.cgi?id=441018&action=review

> LayoutTests/webrtc/captureStream-color-space.html:10
> +    let srcContext = src.getContext("2d");

Could use const I guess here and below.

> LayoutTests/webrtc/captureStream-color-space.html:28
> +    assert_array_approx_equals(actual, expected, 2, `actual = ${actual}, expected = ${expected}`);

If this fails, we probably never hit t.done().
Maybe 2 is too small.

> LayoutTests/webrtc/captureStream-color-space.html:32
> +var t = async_test(function(t) {

Could use async_test(async function...

> LayoutTests/webrtc/captureStream-color-space.html:45
> +    local.createOffer().then(function(desc) {

You could write it with await in a more readable way

[Cameron McCormack (:heycam)]

(In reply to youenn fablet from comment #4)
> > LayoutTests/webrtc/captureStream-color-space.html:28
> > +    assert_array_approx_equals(actual, expected, 2, `actual = ${actual}, expected = ${expected}`);
> 
> If this fails, we probably never hit t.done().

I think the test harness considers a test done when it catches an exception, and we are in a step_func() here.

> Maybe 2 is too small.

I want it to be just small enough that it passes.  We'll see if EWS is OK with it.

[Cameron McCormack (:heycam)]

Created attachment 441701 [details]
Patch for landing

[Cameron McCormack (:heycam)]

Created attachment 442238 [details]
Patch for EWS

[Cameron McCormack (:heycam)]

Created attachment 442254 [details]
Patch for EWS