RESOLVED FIXED Bug 231353
incoming H.264 video is not correctly color managed 
https://bugs.webkit.org/show_bug.cgi?id=231353
Summary incoming H.264 video is not correctly color managed
Cameron McCormack (:heycam)
Reported 2021-10-07 00:05:57 PDT
Attaching a few tests, which use canvas.captureStream(), RTCConnectionPeer, and <video> to convert an sRGB canvas to a video, locally. In Safari on Monterey, the colors are not quite right. Debugging showed that the CMSampleBuffers that are provided by the VTDecompressionSession have the VT default guessed color space attachments of Rec.601. I think these should be sRGB, as that's the default for WebRTC streams.
Attachments
test 1 (1.20 KB, text/html)
2021-10-07 00:06 PDT, Cameron McCormack (:heycam) 		no flags
Details
test 2 (1.41 KB, text/html)
2021-10-07 00:06 PDT, Cameron McCormack (:heycam) 		no flags
Details
test 3 (1.41 KB, text/html)
2021-10-07 00:06 PDT, Cameron McCormack (:heycam) 		no flags
Details
WIP patch (3.27 KB, patch)
2021-10-07 00:09 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
patch (3.43 KB, patch)
2021-10-07 14:45 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.44 KB, patch)
2021-10-12 18:38 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2021-10-07 00:06:17 PDT
Created attachment 440479 [details] test 1
Cameron McCormack (:heycam)
Comment 2 2021-10-07 00:06:32 PDT
Created attachment 440480 [details] test 2
Cameron McCormack (:heycam)
Comment 3 2021-10-07 00:06:48 PDT
Created attachment 440481 [details] test 3
Radar WebKit Bug Importer
Comment 4 2021-10-07 00:09:10 PDT
<rdar://problem/83969311>
Cameron McCormack (:heycam)
Comment 5 2021-10-07 00:09:35 PDT
Created attachment 440483 [details] WIP patch
Cameron McCormack (:heycam)
Comment 6 2021-10-07 14:45:56 PDT
Created attachment 440539 [details] patch
youenn fablet
Comment 7 2021-10-08 00:43:06 PDT
Comment on attachment 440539 [details] patch Let's add a test if possible by adding an Internals API method to grab the color space of webrtc tracks. You can look at Internals.observeMediaStreamTrack and related. As of the test, you can write your own WebRTC test or update an existing one, for instance webrtc/video.html
Cameron McCormack (:heycam)
Comment 8 2021-10-12 16:08:32 PDT
I wanted to use grabNextMediaStreamTrackFrame() and inspect the converted-to-RGB pixel values, but that doesn't seem to be working when the frame is not already RGB. Filed bug 231555 for that. I'll write a test that relies on canvas.drawImage(video), once bug 229025 lands.
Cameron McCormack (:heycam)
Comment 9 2021-10-12 18:38:43 PDT
Created attachment 441028 [details] Patch for landing
Cameron McCormack (:heycam)
Comment 10 2021-10-12 20:03:08 PDT
Test in bug 231645.
EWS
Comment 11 2021-10-13 00:51:19 PDT
Committed r284082 (242910@main): <https://commits.webkit.org/242910@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441028 [details].
Note You need to log in before you can comment on or make changes to this bug.