Bug 231334 – [css-ui] Parsing support for accent-color

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Aditya Keerthi]

https://www.w3.org/TR/css-ui-4/#widget-accent

[Radar WebKit Bug Importer]

<rdar://problem/83955508>

[Aditya Keerthi]

Created attachment 440446 [details]
Patch

[Aditya Keerthi]

Created attachment 440452 [details]
Patch

[Aditya Keerthi]

Needs to be rebased after r283676.

[Aditya Keerthi]

Created attachment 440456 [details]
Patch

[Antti Koivisto]

Comment on attachment 440456 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440456&action=review

> Source/WebCore/css/CSSProperties.json:225
> +            "codegen-properties": {
> +                "color-property": true,
> +                "custom": "All",
> +                "settings-flag": "accentColorEnabled"
> +            },

Does this really need custom codegen? Wouldn't 

"auto-functions": true;

be sufficient?

> Source/WebCore/css/parser/CSSParserContext.cpp:159
> -        | context.aspectRatioEnabled                        << 4
> -        | context.colorContrastEnabled                      << 5
> -        | context.colorFilterEnabled                        << 6
> -        | context.colorMixEnabled                           << 7
> -        | context.constantPropertiesEnabled                 << 8
> -        | context.containmentEnabled                        << 9
> -        | context.cssColor4                                 << 10
> -        | context.deferredCSSParserEnabled                  << 11
> -        | context.individualTransformPropertiesEnabled      << 12
> +        | context.accentColorEnabled                        << 4

Could have just added this to the end and avoided all the movement. Not like these are consistently in sorted order.

[Aditya Keerthi]

Created attachment 440513 [details]
Patch for landing

[Aditya Keerthi]

(In reply to Antti Koivisto from comment #6)
> Comment on attachment 440456 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=440456&action=review
> 
> > Source/WebCore/css/CSSProperties.json:225
> > +            "codegen-properties": {
> > +                "color-property": true,
> > +                "custom": "All",
> > +                "settings-flag": "accentColorEnabled"
> > +            },
> 
> Does this really need custom codegen? Wouldn't 
> 
> "auto-functions": true;
> 
> be sufficient?

This doesn't currently work for color properties.

I'll add support here: https://bugs.webkit.org/show_bug.cgi?id=231376, and then make this change.

> > Source/WebCore/css/parser/CSSParserContext.cpp:159
> > -        | context.aspectRatioEnabled                        << 4
> > -        | context.colorContrastEnabled                      << 5
> > -        | context.colorFilterEnabled                        << 6
> > -        | context.colorMixEnabled                           << 7
> > -        | context.constantPropertiesEnabled                 << 8
> > -        | context.containmentEnabled                        << 9
> > -        | context.cssColor4                                 << 10
> > -        | context.deferredCSSParserEnabled                  << 11
> > -        | context.individualTransformPropertiesEnabled      << 12
> > +        | context.accentColorEnabled                        << 4
> 
> Could have just added this to the end and avoided all the movement. Not like
> these are consistently in sorted order.

Added to the end.

[EWS]

Committed r283742 (242664@main): <https://commits.webkit.org/242664@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440513 [details].