Bug 231376 - CSSProperties.json should not require a 'converter' for color properties
Summary: CSSProperties.json should not require a 'converter' for color properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-07 10:57 PDT by Aditya Keerthi
Modified: 2021-10-14 15:50 PDT (History)
10 users (show)

See Also:


Attachments
Patch (7.21 KB, patch)
2021-10-07 19:04 PDT, Aditya Keerthi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-10-07 10:57:49 PDT
...
Comment 1 Aditya Keerthi 2021-10-07 19:00:24 PDT
Renamed from "makeprop.pl should support 'auto-functions' for color properties", since it technically already does. The only issue was an incorrect value setter, which can be fixed by specifying a 'converter'.

However, I feel 'converter' is redundant for 'color-property', given that we already know we need to cover to a Color.
Comment 2 Aditya Keerthi 2021-10-07 19:00:46 PDT
(In reply to Aditya Keerthi from comment #1)
> Renamed from "makeprop.pl should support 'auto-functions' for color
> properties", since it technically already does. The only issue was an
> incorrect value setter, which can be fixed by specifying a 'converter'.
> 
> However, I feel 'converter' is redundant for 'color-property', given that we
> already know we need to cover to a Color.

s/cover/convert/
Comment 3 Aditya Keerthi 2021-10-07 19:04:27 PDT
Created attachment 440565 [details]
Patch
Comment 4 Radar WebKit Bug Importer 2021-10-14 10:58:15 PDT
<rdar://problem/84264255>
Comment 5 Antti Koivisto 2021-10-14 11:40:32 PDT
Comment on attachment 440565 [details]
Patch

nice!
Comment 6 EWS 2021-10-14 15:50:32 PDT
Committed r284207 (243018@main): <https://commits.webkit.org/243018@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440565 [details].