Bug 231292 – Ensure that the top layer is always anchored to the RenderView

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

see https://fullscreen.spec.whatwg.org/#new-stacking-layer

[zalan]

Created attachment 440374 [details]
Patch

[EWS]

Committed r283634 (242585@main): <https://commits.webkit.org/242585@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440374 [details].

[Radar WebKit Bug Importer]

<rdar://problem/83941854>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 231332

[Tim Nguyen (:ntim)]

Created attachment 441416 [details]
Patch

[Tim Nguyen (:ntim)]

Created attachment 441487 [details]
Patch

[Tim Nguyen (:ntim)]

Created attachment 441604 [details]
Testcase that fails with top layer reparenting patch

[Brent Fulgham]

This is now being tracked by rdar://84618684.

[Tim Nguyen (:ntim)]

Created attachment 443512 [details]
Patch

[Tim Nguyen (:ntim)]

Created attachment 446043 [details]
Patch

[Tim Nguyen (:ntim)]

Created attachment 446044 [details]
Patch

[Tim Nguyen (:ntim)]

Created attachment 447750 [details]
Patch

[zalan]

Created attachment 448465 [details]
Patch

[Tim Nguyen (:ntim)]

Comment on attachment 448465 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448465&action=review

Thanks for taking another look at this!

> Source/WebCore/rendering/RenderObject.cpp:666
> +    auto containingBlockForRenderer = [](const auto& renderer) -> RenderBlock* {
> +        if (isInTopLayerOrBackdrop(renderer.style(), renderer.element()))
> +            return &renderer.view();
>          if (renderer.isAbsolutelyPositioned())
>              return renderer.containingBlockForAbsolutePosition();
>          if (renderer.isFixedPositioned())

containingBlockForAbsolutePosition/containingBlockForFixedPosition is also used in LogicalSelectionOffsetCaches.cpp / LogicalSelectionOffsetCaches.h

Should we adapt those instead?

[zalan]

(In reply to Tim Nguyen (:ntim) from comment #14)
> Comment on attachment 448465 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=448465&action=review
> 
> Thanks for taking another look at this!
> 
> > Source/WebCore/rendering/RenderObject.cpp:666
> > +    auto containingBlockForRenderer = [](const auto& renderer) -> RenderBlock* {
> > +        if (isInTopLayerOrBackdrop(renderer.style(), renderer.element()))
> > +            return &renderer.view();
> >          if (renderer.isAbsolutelyPositioned())
> >              return renderer.containingBlockForAbsolutePosition();
> >          if (renderer.isFixedPositioned())
> 
> containingBlockForAbsolutePosition/containingBlockForFixedPosition is also
> used in LogicalSelectionOffsetCaches.cpp / LogicalSelectionOffsetCaches.h
> 
> Should we adapt those instead?
will do a bit of a cleanup there.

[EWS]

Committed r287683 (245779@main): <https://commits.webkit.org/245779@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448465 [details].