Bug 231225 - createImageBitmap using a HLS video as source is always black
Summary: createImageBitmap using a HLS video as source is always black
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2021-10-05 03:27 PDT by Jean-Yves Avenard [:jya]
Modified: 2021-10-05 16:43 PDT (History)
7 users (show)

See Also:


Attachments
Patch (14.72 KB, patch)
2021-10-05 07:01 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-10-05 03:27:21 PDT
Seen with bug 231005

MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput checks that we have a video track before creating an image. However to checks if a video track exists it calls AVAssetTrack* firstEnabledVideoTrack = firstEnabledTrack(safeAVAssetTracksForVisualMedia());


safeAVAssetTracksForVisualMedia queries m_avAsset (a AVURLAsset) for the list of track.

However, with HLS the AVURLAsset doesn't contain any tracks, instead they are found in the AVPlayerItem instead.
Comment 1 Radar WebKit Bug Importer 2021-10-05 06:48:04 PDT
<rdar://problem/83884031>
Comment 2 Jean-Yves Avenard [:jya] 2021-10-05 07:01:12 PDT
Created attachment 440208 [details]
Patch
Comment 3 EWS 2021-10-05 16:43:36 PDT
Committed r283585 (242543@main): <https://commits.webkit.org/242543@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440208 [details].