Bug 231005 - REGRESSION (Monterey): paramountplus.com: Cannot enter fullscreen in Safari
Summary: REGRESSION (Monterey): paramountplus.com: Cannot enter fullscreen in Safari
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-29 23:41 PDT by Jean-Yves Avenard [:jya]
Modified: 2021-10-05 16:28 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.85 KB, patch)
2021-09-29 23:52 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (2.99 KB, patch)
2021-09-29 23:55 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (12.17 KB, patch)
2021-10-01 05:50 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (12.16 KB, patch)
2021-10-01 06:01 PDT, Jean-Yves Avenard [:jya]
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (12.33 KB, patch)
2021-10-01 06:07 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (19.22 KB, patch)
2021-10-02 00:54 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff
Patch (4.32 KB, patch)
2021-10-05 00:01 PDT, Jean-Yves Avenard [:jya]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-09-29 23:41:20 PDT
REGRESSION (Monterey): paramountplus.com: Cannot enter fullscreen in Safari
Comment 1 Jean-Yves Avenard [:jya] 2021-09-29 23:42:03 PDT
rdar://83606128
Comment 2 Jean-Yves Avenard [:jya] 2021-09-29 23:52:44 PDT
Created attachment 439701 [details]
Patch
Comment 3 Jean-Yves Avenard [:jya] 2021-09-29 23:55:17 PDT
Created attachment 439702 [details]
Patch

Improve ChangeLog
Comment 4 Eric Carlson 2021-09-30 08:32:02 PDT
Comment on attachment 439702 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439702&action=review

> Source/WebCore/ChangeLog:14
> +        We do not have the infrastructure to easily test interactiong with encrypted

s/interactiong/interacting/
Comment 5 Jean-Yves Avenard [:jya] 2021-09-30 15:40:50 PDT
turn out this will break readbacks with HLS content
Comment 6 Jean-Yves Avenard [:jya] 2021-10-01 05:50:04 PDT
Created attachment 439844 [details]
Patch
Comment 7 Jean-Yves Avenard [:jya] 2021-10-01 06:01:01 PDT
Created attachment 439845 [details]
Patch

rebase
Comment 8 Jean-Yves Avenard [:jya] 2021-10-01 06:07:59 PDT
Created attachment 439846 [details]
Patch

fix header on non-internal build
Comment 9 Jean-Yves Avenard [:jya] 2021-10-02 00:54:14 PDT
Created attachment 439960 [details]
Patch

Remove AVAssetTrack SPI, it crashes ; instead do what it does internally (but simplified with no memory allocation
Comment 10 Jean-Yves Avenard [:jya] 2021-10-05 00:01:04 PDT
Created attachment 440169 [details]
Patch

As discussed, only implement the easy workaround and avoid the use of new SPI
Comment 11 EWS 2021-10-05 16:28:12 PDT
Committed r283583 (242541@main): <https://commits.webkit.org/242541@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440169 [details].