Bug 231060 - Implement missing functions in PrivateClickMeasurementDaemonClient
Summary: Implement missing functions in PrivateClickMeasurementDaemonClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-30 20:53 PDT by Alex Christensen
Modified: 2021-10-05 14:50 PDT (History)
2 users (show)

See Also:

Attachments
Patch (27.48 KB, patch)
2021-09-30 20:54 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (26.31 KB, patch)
2021-10-01 09:28 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (60.32 KB, patch)
2021-10-04 17:23 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (60.32 KB, patch)
2021-10-04 17:25 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (65.41 KB, patch)
2021-10-04 17:41 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (65.47 KB, patch)
2021-10-04 22:54 PDT, Alex Christensen 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-09-30 20:53:08 PDT 
Implement missing functions in PrivateClickMeasurementDaemonClient
Comment 1 Alex Christensen 2021-09-30 20:54:31 PDT 
Created attachment 439817 [details]
Patch
Comment 2 Alex Christensen 2021-10-01 09:28:37 PDT 
Created attachment 439867 [details]
Patch
Comment 3 Alex Christensen 2021-10-04 17:23:08 PDT 
Created attachment 440125 [details]
Patch
Comment 4 Alex Christensen 2021-10-04 17:25:01 PDT 
Created attachment 440126 [details]
Patch
Comment 5 Alex Christensen 2021-10-04 17:41:57 PDT 
Created attachment 440127 [details]
Patch
Comment 6 Alex Christensen 2021-10-04 22:54:41 PDT 
Created attachment 440159 [details]
Patch
Comment 7 Chris Dumez 2021-10-05 11:02:14 PDT 
Comment on attachment 440159 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440159&action=review

> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h:63
> +    explicit ConnectionToMachService(CString&& machServiceName, NetworkSession&);

Probably don’t need the explicit.

> Source/WebKit/Shared/EntryPointUtilities/Cocoa/Daemon/PCMDaemonConnectionSet.mm:47
> +    m_connections.set(connection, DebugModeEnabled::No);

add() is more efficient and should suffice given that you don’t expect the key to exist.
Comment 8 Alex Christensen 2021-10-05 11:12:42 PDT 
Done.
http://trac.webkit.org/r283559
Comment 9 Radar WebKit Bug Importer 2021-10-05 11:13:21 PDT 
<rdar://problem/83895136>