WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
231060
Implement missing functions in PrivateClickMeasurementDaemonClient
https://bugs.webkit.org/show_bug.cgi?id=231060
Summary
Implement missing functions in PrivateClickMeasurementDaemonClient
Alex Christensen
Reported
2021-09-30 20:53:08 PDT
Implement missing functions in PrivateClickMeasurementDaemonClient
Attachments
Patch
(27.48 KB, patch)
2021-09-30 20:54 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(26.31 KB, patch)
2021-10-01 09:28 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(60.32 KB, patch)
2021-10-04 17:23 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(60.32 KB, patch)
2021-10-04 17:25 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(65.41 KB, patch)
2021-10-04 17:41 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(65.47 KB, patch)
2021-10-04 22:54 PDT
,
Alex Christensen
cdumez
: review+
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2021-09-30 20:54:31 PDT
Created
attachment 439817
[details]
Patch
Alex Christensen
Comment 2
2021-10-01 09:28:37 PDT
Created
attachment 439867
[details]
Patch
Alex Christensen
Comment 3
2021-10-04 17:23:08 PDT
Created
attachment 440125
[details]
Patch
Alex Christensen
Comment 4
2021-10-04 17:25:01 PDT
Created
attachment 440126
[details]
Patch
Alex Christensen
Comment 5
2021-10-04 17:41:57 PDT
Created
attachment 440127
[details]
Patch
Alex Christensen
Comment 6
2021-10-04 22:54:41 PDT
Created
attachment 440159
[details]
Patch
Chris Dumez
Comment 7
2021-10-05 11:02:14 PDT
Comment on
attachment 440159
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=440159&action=review
> Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementConnection.h:63 > + explicit ConnectionToMachService(CString&& machServiceName, NetworkSession&);
Probably don’t need the explicit.
> Source/WebKit/Shared/EntryPointUtilities/Cocoa/Daemon/PCMDaemonConnectionSet.mm:47 > + m_connections.set(connection, DebugModeEnabled::No);
add() is more efficient and should suffice given that you don’t expect the key to exist.
Alex Christensen
Comment 8
2021-10-05 11:12:42 PDT
Done.
http://trac.webkit.org/r283559
Radar WebKit Bug Importer
Comment 9
2021-10-05 11:13:21 PDT
<
rdar://problem/83895136
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug