Bug 231059 – [GStreamer] fast/mediastream/video-rotation tests are failing due to missing TestController::takeViewPortSnapshot

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Lauro Moura]

fast/mediastream/video-rotation.html
fast/mediastream/video-rotation-gpu-process-crash.html

Added in 242095@main and 242172@main respectively.

Test fails with an empty ErrorEvent raised trying to load a dataURL image from testRunner.takeViewPortSnapshot (new method, only implemented in Cocoa).

[Philippe Normand]

Also, WKPageSetMockCameraOrientation is not implemented for non-cocoa ports...

[Philippe Normand]

Created attachment 441572 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 441572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441572&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:3013
> +        GST_DEBUG_OBJECT(pad.get(), "No sticky tag event, applying no rotation.");

This message is confusing, since it says you're not applying rotation but you're applying orientation in the end. Or maybe I'm misunderstanding...

[Philippe Normand]

Comment on attachment 441572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441572&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:3013
>> +        GST_DEBUG_OBJECT(pad.get(), "No sticky tag event, applying no rotation.");
> 
> This message is confusing, since it says you're not applying rotation but you're applying orientation in the end. Or maybe I'm misunderstanding...

Ah yes, bad consequence of the refactor, this was previously in !tagsEvent scope. Nice catch!

[Philippe Normand]

Committed r284368 (243153@main): <https://commits.webkit.org/243153@main>

[Radar WebKit Bug Importer]

<rdar://problem/84367556>