Bug 229792 – <video> element rendered incorrectly when provided with a portrait orientation stream in Safari 15

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[Alexander Khovansky]

Created attachment 437113 [details]
Bug screenshot in codepen debug view

<video> element with vertical video appears to be rendered with a black landscape-oriented rectangle behind it.
First noticed when using getUserMedia on iPhone in iOS 15 (19A5340a). Same issue is reproducible on iPadOS 15 (same build) when used in portrait mode.

Reproduction codepen: https://codepen.io/alx-khovansky/pen/PojNgqR
Attached a screenshot taken in codepen debug view, notice the black rectangle sticking from the sides of the video.

[Alexey Proskuryakov]

> First noticed when using getUserMedia on iPhone in iOS 15 

Could you please confirm whether this behaves as expected on iOS 14.x?

[Radar WebKit Bug Importer]

<rdar://problem/82776741>

[Alexander Khovansky]

Created attachment 437373 [details]
Same demo running on iOS 14.7.1

Attached a new screenshot: same demo running on iOS 14.7.1.
Video is rendered normally.

[Naoto Takahashi]

I'm facing the same problem.

I found that setting the object-fit of the video element to none temporarily solves the problem, however it changes that setting.

The black rectangle disappears when there is inline content to the left of the video, so adding transparent colored text with a negative margin seems to be a temporary workaround.

CodePen :
https://codepen.io/sandabu/pen/xxrRZqx

[Dag-Inge Aas]

I can reproduce this in the basic getUserMedia test over on webrtc samples as well. 

https://webrtc.github.io/samples/src/content/getusermedia/gum/

Tested on iPhone XR MRY42QN/A running 15.0 Public Beta 8 (19A5340a)

[Dag-Inge Aas]

Created attachment 438241 [details]
Basic peer connection demo

Shows that this is broken also in basicPeerConnection demo for both local and remote video in portrait mode

[Dag-Inge Aas]

Got an update to 19A344, still not working

[Dag-Inge Aas]

This hit production now on iOS 15 (19A346) and it's still as broken as before.

[youenn fablet]

Created attachment 438940 [details]
Patch

[youenn fablet]

Created attachment 438972 [details]
Patch

[Eric Carlson]

Comment on attachment 438972 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438972&action=review

> Source/WebCore/ChangeLog:10
> +        We also need to ompute m_sampleBufferDisplayLayer position based on m_rootLayer coordinates.

s/ompute/compute/

> LayoutTests/fast/mediastream/video-rotation.html:22
> +    await new Promise(resolve => setTimeout(resolve, 3000));

This hard coded wait is unfortunate because it will almost always be way too long, but it can presumably be too short on a very heavily loaded machine. Can we avoid it by doing something like rendering to a canvas until we see that someone has been rendered?

[youenn fablet]

(In reply to Eric Carlson from comment #11)
> Comment on attachment 438972 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=438972&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        We also need to ompute m_sampleBufferDisplayLayer position based on m_rootLayer coordinates.
> 
> s/ompute/compute/
> 
> > LayoutTests/fast/mediastream/video-rotation.html:22
> > +    await new Promise(resolve => setTimeout(resolve, 3000));
> 
> This hard coded wait is unfortunate because it will almost always be way too
> long, but it can presumably be too short on a very heavily loaded machine.
> Can we avoid it by doing something like rendering to a canvas until we see
> that someone has been rendered?

Hum, we can try to improve things.
A canvas might not be good enough since it is not tightly related to the rendering code path.
But I can add a test runner API that gets a screenshot and we can then do some measurements on it (and redo screenshots as needed).

[youenn fablet]

Created attachment 439138 [details]
Use new testRunner API

[EWS]

Committed r283035 (242095@main): <https://commits.webkit.org/242095@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 439138 [details].

[youenn fablet]

*** Bug 231461 has been marked as a duplicate of this bug. ***

[youenn fablet]

This should be fixed in latest iOS 15 beta.

[youenn fablet]

(In reply to youenn fablet from comment #16)
> This should be fixed in latest iOS 15 beta.

I take it back actually.

[Alexander Khovansky]

Looked fixed to me on 15.1 beta 3.

[youenn fablet]

*** Bug 231903 has been marked as a duplicate of this bug. ***

[youenn fablet]

*** Bug 232039 has been marked as a duplicate of this bug. ***