Bug 231045 - Add SPI to launch a service service worker in a WKWebView and expose service worker to injected bundle
Summary: Add SPI to launch a service service worker in a WKWebView and expose service ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 230649
Blocks:
  Show dependency tree / graph
 
Reported: 2021-09-30 16:28 PDT by Chris Dumez
Modified: 2021-10-04 16:15 PDT (History)
16 users (show)

See Also:

Attachments
WIP Patch (122.60 KB, patch)
2021-09-30 16:28 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (124.26 KB, patch)
2021-09-30 16:46 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
WIP Patch (124.25 KB, patch)
2021-10-01 07:40 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (144.60 KB, patch)
2021-10-01 08:08 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (144.52 KB, patch)
2021-10-01 13:48 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (144.68 KB, patch)
2021-10-04 13:33 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-09-30 16:28:04 PDT 
Add SPI to launch a service service worker in a WKWebView and expose service worker to injected bundle.
Comment 1 Chris Dumez 2021-09-30 16:28:34 PDT 
Created attachment 439791 [details]
WIP Patch
Comment 2 EWS Watchlist 2021-09-30 16:29:51 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Radar WebKit Bug Importer 2021-09-30 16:44:34 PDT 
<rdar://problem/83744069>
Comment 4 Chris Dumez 2021-09-30 16:46:16 PDT 
Created attachment 439796 [details]
WIP Patch
Comment 5 Chris Dumez 2021-10-01 07:40:57 PDT 
Created attachment 439858 [details]
WIP Patch
Comment 6 Chris Dumez 2021-10-01 08:08:22 PDT 
Created attachment 439862 [details]
Patch
Comment 7 Timothy Hatcher 2021-10-01 11:35:57 PDT 
Comment on attachment 439862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439862&action=review

> Source/WebCore/page/Page.cpp:3694
> +    // FIXME: We currently do not support non-normal worlds in service workers.

This will be fine for our needs.

> Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:658
> +    WKBundlePageServiceWorkerGlobalObjectIsAvailableForFrameCallback         serviceWorkerGlobalObjectIsAvailableForFrame;

One space off in the alignment of serviceWorkerGlobalObjectIsAvailableForFrame.
Comment 8 Chris Dumez 2021-10-01 13:48:58 PDT 
Created attachment 439904 [details]
Patch
Comment 9 Geoffrey Garen 2021-10-04 12:40:26 PDT 
Comment on attachment 439904 [details]
Patch

r=me
Comment 10 EWS 2021-10-04 12:42:48 PDT 
Tools/Scripts/svn-apply failed to apply attachment 439904 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 11 Chris Dumez 2021-10-04 13:33:37 PDT 
Created attachment 440099 [details]
Patch
Comment 12 EWS 2021-10-04 16:15:34 PDT 
Committed r283522 (242489@main): <https://commits.webkit.org/242489@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440099 [details].