Bug 231045 – Add SPI to launch a service service worker in a WKWebView and expose service worker to injected bundle

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Add SPI to launch a service service worker in a WKWebView and expose service worker to injected bundle.

[Chris Dumez]

Created attachment 439791 [details]
WIP Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Radar WebKit Bug Importer]

<rdar://problem/83744069>

[Chris Dumez]

Created attachment 439796 [details]
WIP Patch

[Chris Dumez]

Created attachment 439858 [details]
WIP Patch

[Chris Dumez]

Created attachment 439862 [details]
Patch

[Timothy Hatcher]

Comment on attachment 439862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=439862&action=review

> Source/WebCore/page/Page.cpp:3694
> +    // FIXME: We currently do not support non-normal worlds in service workers.

This will be fine for our needs.

> Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:658
> +    WKBundlePageServiceWorkerGlobalObjectIsAvailableForFrameCallback         serviceWorkerGlobalObjectIsAvailableForFrame;

One space off in the alignment of serviceWorkerGlobalObjectIsAvailableForFrame.

[Chris Dumez]

Created attachment 439904 [details]
Patch

[Geoffrey Garen]

Comment on attachment 439904 [details]
Patch

r=me

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 439904 [details] to trunk.
Please resolve the conflicts and upload a new patch.

[Chris Dumez]

Created attachment 440099 [details]
Patch

[EWS]

Committed r283522 (242489@main): <https://commits.webkit.org/242489@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440099 [details].