Bug 230552 - NetworkRTCUDPSocketCocoaConnections should handle NAT64 IP addresses correctly
Summary: NetworkRTCUDPSocketCocoaConnections should handle NAT64 IP addresses correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
: 231733 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-09-21 07:06 PDT by youenn fablet
Modified: 2021-10-19 03:22 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.03 KB, patch)
2021-09-21 07:18 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.33 KB, patch)
2021-09-21 07:46 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.33 KB, patch)
2021-09-21 07:55 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (14.82 KB, patch)
2021-09-21 08:36 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
toBefreed fix (14.82 KB, patch)
2021-09-21 08:44 PDT, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Fix missing export (17.26 KB, patch)
2021-09-21 09:39 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (17.26 KB, patch)
2021-09-21 10:44 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-09-21 07:06:43 PDT 
NetworkRTCUDPSocketCocoaConnections should handle NAT64 IP addresses correctly
Comment 1 youenn fablet 2021-09-21 07:07:39 PDT 
<rdar://83297256>
Comment 2 youenn fablet 2021-09-21 07:18:08 PDT 
Created attachment 438812 [details]
Patch
Comment 3 youenn fablet 2021-09-21 07:46:28 PDT 
Created attachment 438817 [details]
Patch
Comment 4 youenn fablet 2021-09-21 07:55:45 PDT 
Created attachment 438818 [details]
Patch
Comment 5 Alex Christensen 2021-09-21 08:13:39 PDT 
Comment on attachment 438818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438818&action=review

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:158
> +    std::unique_ptr<struct ifaddrs> toBefreed(interfaces);

Capital F

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:168
> +        return nw_nat64_does_interface_index_support_nat64(if_nametoindex(interface->ifa_name));

Documentation says this was only intended for one client.  We are not that client.

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:182
> +    return "0.0.0.0";

Why this address?
Comment 6 Alex Christensen 2021-09-21 08:19:50 PDT 
Comment on attachment 438818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438818&action=review

> Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:154
> +#if USE(APPLE_INTERNAL_SDK)

I think it would be better to add NetworkSPI.h rather than have different behavior like this only in internal builds.  That is what our SPI headers are for.
Comment 7 youenn fablet 2021-09-21 08:36:41 PDT 
Created attachment 438824 [details]
Patch
Comment 8 youenn fablet 2021-09-21 08:44:11 PDT 
Created attachment 438826 [details]
toBefreed fix
Comment 9 youenn fablet 2021-09-21 09:39:00 PDT 
Created attachment 438830 [details]
Fix missing export
Comment 10 EWS 2021-09-21 10:14:41 PDT 
ChangeLog entry in Source/ThirdParty/libwebrtc/ChangeLog contains OOPS!.
Comment 11 youenn fablet 2021-09-21 10:44:31 PDT 
Created attachment 438833 [details]
Patch
Comment 12 EWS 2021-09-21 11:30:44 PDT 
Committed r282831 (241962@main): <https://commits.webkit.org/241962@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438833 [details].
Comment 13 youenn fablet 2021-10-19 03:22:05 PDT 
*** Bug 231733 has been marked as a duplicate of this bug. ***