Bug 230495 - [Cocoa] Videos sometimes don't render when loaded in the GPU process
Summary: [Cocoa] Videos sometimes don't render when loaded in the GPU process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks: 230500
  Show dependency tree / graph
 
Reported: 2021-09-20 12:02 PDT by Eric Carlson
Modified: 2021-10-21 18:19 PDT (History)
7 users (show)

See Also:

Attachments
Patch (9.37 KB, patch)
2021-09-20 13:13 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch for landing (9.59 KB, patch)
2021-09-20 13:20 PDT, Eric Carlson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (10.29 KB, patch)
2021-09-20 13:33 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2021-09-20 12:02:07 PDT 
Videos sometimes don't render when loaded in the GPU process
Comment 1 Eric Carlson 2021-09-20 12:02:29 PDT 
rdar://83205407
Comment 2 Eric Carlson 2021-09-20 13:13:42 PDT 
Created attachment 438717 [details]
Patch
Comment 3 Jer Noble 2021-09-20 13:15:25 PDT 
Comment on attachment 438717 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438717&action=review

r=me with nits:

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:244
> +    ALWAYS_LOG(LOGIDENTIFIER);

Maybe, `ALWAYS_LOG(LOGIDENTIFIER, visible)` ?

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:356
> +    ALWAYS_LOG(LOGIDENTIFIER);

Maybe, `ALWAYS_LOG(LOGIDENTIFIER, m_player->readyState())` ?
Comment 4 Eric Carlson 2021-09-20 13:19:49 PDT 
Comment on attachment 438717 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438717&action=review

>> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:244
>> +    ALWAYS_LOG(LOGIDENTIFIER);
> 
> Maybe, `ALWAYS_LOG(LOGIDENTIFIER, visible)` ?

Good idea.

>> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:356
>> +    ALWAYS_LOG(LOGIDENTIFIER);
> 
> Maybe, `ALWAYS_LOG(LOGIDENTIFIER, m_player->readyState())` ?

Ditto
Comment 5 Eric Carlson 2021-09-20 13:20:49 PDT 
Created attachment 438718 [details]
Patch for landing
Comment 6 Eric Carlson 2021-09-20 13:33:18 PDT 
Created attachment 438721 [details]
Patch for landing
Comment 7 EWS 2021-09-20 16:08:08 PDT 
Committed r282789 (241924@main): <https://commits.webkit.org/241924@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438721 [details].