Bug 230471 - [GPUP] Videos appear black but audio plays normally
Summary: [GPUP] Videos appear black but audio plays normally
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-19 20:18 PDT by Peng Liu
Modified: 2021-09-20 13:38 PDT (History)
8 users (show)

See Also:


Attachments
[fast-cq] Patch (2.04 KB, patch)
2021-09-19 20:37 PDT, Peng Liu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2021-09-19 20:18:58 PDT
Videos appear black but audio plays normally
Comment 1 Peng Liu 2021-09-19 20:33:58 PDT
<rdar://82121369>
Comment 2 Peng Liu 2021-09-19 20:37:48 PDT
Created attachment 438633 [details]
[fast-cq] Patch
Comment 3 youenn fablet 2021-09-20 03:22:20 PDT
Comment on attachment 438633 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438633&action=review

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:139
> +        destroyContextVideoRenderer();

Can we add a test?
Comment 4 Peng Liu 2021-09-20 13:35:24 PDT
Comment on attachment 438633 [details]
[fast-cq] Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=438633&action=review

>> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:139
>> +        destroyContextVideoRenderer();
> 
> Can we add a test?

We don't have a good way to test this for now. Will follow up in bug 230500.
Comment 5 EWS 2021-09-20 13:38:07 PDT
Committed r282774 (241909@main): <https://commits.webkit.org/241909@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 438633 [details].