Bug 230488 - [ BigSur wk2 arm64 ] imported/w3c/web-platform-tests/infrastructure/reftest-wait.html is a flaky image failure
Summary: [ BigSur wk2 arm64 ] imported/w3c/web-platform-tests/infrastructure/reftest-w...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Mac (Apple Silicon) Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-20 10:39 PDT by ayumi_kojima
Modified: 2022-04-23 19:21 PDT (History)
9 users (show)

See Also:


Attachments
Image diff (2.72 KB, image/png)
2021-09-20 10:40 PDT, ayumi_kojima
no flags Details
test list (435.57 KB, text/plain)
2022-04-22 09:03 PDT, Karl Rackler
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description ayumi_kojima 2021-09-20 10:39:49 PDT
imported/w3c/web-platform-tests/infrastructure/reftest-wait.html

Is flaky image failing on BigSur wk2 arm64.

History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Finfrastructure%2Freftest-wait.html

Result page: https://build.webkit.org/results/Apple-BigSur-Release-AppleSilicon-WK2-Tests/r282745%20(4008)/results.html
Comment 1 ayumi_kojima 2021-09-20 10:40:53 PDT
Created attachment 438694 [details]
Image diff
Comment 2 Radar WebKit Bug Importer 2021-09-20 10:41:23 PDT
<rdar://problem/83313533>
Comment 3 ayumi_kojima 2021-09-20 10:46:45 PDT
Marked test expectations: https://trac.webkit.org/changeset/282759/webkit
Comment 4 Alexey Proskuryakov 2021-09-20 13:38:13 PDT
This test just checks if basic WPT infrastructure works. So if it's flaky, then all reftest-wait tests are.

So this is particularly important to look into.
Comment 5 Sam Sneddon [:gsnedders] 2021-09-21 06:34:01 PDT
It appears like it's just some pixels (not even around the edge of the square) with a very slightly different colour. Any idea, Simon?
Comment 6 ayumi_kojima 2021-09-21 13:28:17 PDT
I was able to reproduce the image failure locally on BigSur arm64 at TOT and the oldest revision available (r268271) using run-webkit-tests --force --iterations 100 --exit-after-n-failures 1 imported/w3c/web-platform-tests/infrastructure/reftest-wait.html -f
Comment 7 Simon Fraser (smfr) 2021-09-21 13:31:50 PDT
I'm not sure we even support reftest-wait.
Comment 8 Sam Sneddon [:gsnedders] 2021-09-22 10:28:14 PDT
Darin added it in https://bugs.webkit.org/show_bug.cgi?id=186045
Comment 9 Simon Fraser (smfr) 2021-09-22 11:05:47 PDT
The diff is pixel fuzz, so it's one of those bugs where some underlying graphics state is different, which might be something WebKit is doing, or something an underlying framework is doing.

It would be nice to know what sequence of tests reliably cause this pixel fuzz.
Comment 10 Karl Rackler 2022-04-22 09:02:16 PDT
[ macOS wk2 arm64 ] imported/w3c/web-platform-tests/infrastructure/reftest-wait.html is a flaky failure/image failure/timeout/crash

Description:
imported/w3c/web-platform-tests/infrastructure/reftest-wait.html

Updating to include this is affecting Monterey wk2 arm64.

There was not one commit that I observed causing this issue.  This test seems to have been flaky from the start on Big Sur and Monterey.  It has been reproduced with ToT and oldest available spade previously. 

The first failure for Monterey that I saw on the dashboard was 3/18/2022 at r291506, but this does not appear relevant to causing this issue.

I was unable reproduce this on Monterey on Tot (r293204) or oldest available spade (r2826320, but I was able to grab the test list.

History:
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Finfrastructure%2Freftest-wait.html&platform=mac&limit=50000&architecture=arm64&flavor=wk2

Link to Image Diff:
https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-Tests/249887@main%20(2824)/imported/w3c/web-platform-tests/infrastructure/reftest-wait-diffs.html

I have marked this test as a flaky failure while this issue is investigated.
Comment 11 Karl Rackler 2022-04-22 09:03:40 PDT
Created attachment 458149 [details]
test list
Comment 12 Karl Rackler 2022-04-22 09:08:26 PDT
Pull request: https://github.com/WebKit/WebKit/pull/360
Comment 13 Karl Rackler 2022-04-22 09:10:15 PDT
(In reply to Karl Rackler from comment #10)
> [ macOS wk2 arm64 ]
> imported/w3c/web-platform-tests/infrastructure/reftest-wait.html is a flaky
> failure/image failure/timeout/crash
> 
> Description:
> imported/w3c/web-platform-tests/infrastructure/reftest-wait.html
> 
> Updating to include this is affecting Monterey wk2 arm64.
> 
> There was not one commit that I observed causing this issue.  This test
> seems to have been flaky from the start on Big Sur and Monterey.  It has
> been reproduced with ToT and oldest available spade previously. 
> 
> The first failure for Monterey that I saw on the dashboard was 3/18/2022 at
> r291506, but this does not appear relevant to causing this issue.
> 
> I was unable reproduce this on Monterey on Tot (r293204) or oldest available
> spade (r2826320, but I was able to grab the test list.
> 
> History:
> https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-
> platform-tests%2Finfrastructure%2Freftest-wait.
> html&platform=mac&limit=50000&architecture=arm64&flavor=wk2
> 
> Link to Image Diff:
> https://build.webkit.org/results/Apple-Monterey-Release-AppleSilicon-WK2-
> Tests/249887@main%20(2824)/imported/w3c/web-platform-tests/infrastructure/
> reftest-wait-diffs.html
> 
> I have marked this test as a flaky failure while this issue is investigated.

This should read ** [ macOS wk2 arm64 ] imported/w3c/web-platform-tests/infrastructure/reftest-wait.html is a flaky failure **
Comment 14 EWS 2022-04-22 09:12:07 PDT
Committed r293223 (249892@main): <https://commits.webkit.org/249892@main>

Reviewed commits have been landed. Closing PR #360 and removing active labels.
Comment 15 Karl Rackler 2022-04-22 09:13:24 PDT
Reopened because the issue is still being investigated.