Bug 230081 – Enable IPCMessages debug logging for non-Cocoa ports

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Fujii Hironori]

Enable IPCMessages debug logging for non-Cocoa ports

r282177 disabled IPCMessages debug logging for non-Cocoa ports.
Bug 230075 fixed the fundamental problem. Let's enable it.

[Fujii Hironori]

Created attachment 437707 [details]
Patch

[Cameron McCormack (:heycam)]

Not a reviewer, but this looks OK to me.

[Don Olmstead]

Comment on attachment 437707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437707&action=review

> Source/WebKit/Scripts/webkit/tests/MessageArgumentDescriptions.cpp:135
> +#if ENABLE(IPC_TESTING_API)

Feel that whatever the guards are in this file should also be in the header so things are compile errors rather than linker.

Agree with Alex on the r+

[Don Olmstead]

One additional issue though that I saw when I was working through this after that build break was that if you actually enable the ipc testing on Windows the build would fail because

https://github.com/WebKit/WebKit/blob/main/Source/WebKit/Platform/IPC/JSIPCBinding.h#L94-L95

ends up being multiply defined due to the typedefs of those two being the same.

[Fujii Hironori]

Comment on attachment 437707 [details]
Patch

Clearing flags on attachment: 437707

Committed r282236 (241520@main): <https://commits.webkit.org/241520@main>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/82939596>

[Fujii Hironori]

(In reply to Don Olmstead from comment #3)
> Feel that whatever the guards are in this file should also be in the header
> so things are compile errors rather than linker.

Oops. I overlooked this review comment. Reopened to attach one more patch.

[Fujii Hironori]

Created attachment 437777 [details]
Patch

[Fujii Hironori]

(In reply to Don Olmstead from comment #4)
> One additional issue though that I saw when I was working through this after
> that build break was that if you actually enable the ipc testing on Windows
> the build would fail because
> 
> https://github.com/WebKit/WebKit/blob/main/Source/WebKit/Platform/IPC/
> JSIPCBinding.h#L94-L95
> 
> ends up being multiply defined due to the typedefs of those two being the
> same.

Yup. I know. IPC_TESTING_API adds some JS API. But, there are no test cases in OpenSource. It seems usable only for Apple.

[Fujii Hironori]

Committed r282406 (241667@main): <https://commits.webkit.org/241667@main>