Bug 230075 - generated MessageArgumentDescriptions.cpp can't compile for non-Cocoa ports due to missing headers
Summary: generated MessageArgumentDescriptions.cpp can't compile for non-Cocoa ports d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-08 18:06 PDT by Fujii Hironori
Modified: 2021-09-08 20:32 PDT (History)
8 users (show)

See Also:


Attachments
Patch (9.32 KB, patch)
2021-09-08 18:25 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2021-09-08 18:06:29 PDT
generated MessageArgumentDescriptions.cpp can't compile for non-Cocoa ports due to missing headers

It includes platform specific headers unconditionally.

> WebKit\DerivedSources\MessageArgumentDescriptions.cpp(366): fatal error C1083: Cannot open include file: 'WebCore/CAAudioStreamDescription.h': No such file or directory

generate_message_argument_description_implementation generates the #includes, it should take receiver.condition into account.
Comment 1 Fujii Hironori 2021-09-08 18:25:26 PDT
Created attachment 437693 [details]
Patch
Comment 2 Fujii Hironori 2021-09-08 20:31:18 PDT
Comment on attachment 437693 [details]
Patch

Clearing flags on attachment: 437693

Committed r282190 (241477@main): <https://commits.webkit.org/241477@main>
Comment 3 Fujii Hironori 2021-09-08 20:31:22 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2021-09-08 20:32:18 PDT
<rdar://problem/82906144>