Bug 230043 - REGRESSION(r282060) [GTK] API test /WebKit2Gtk/TestContextMenu /webkit/WebKitWebView/default-menu is failing
Summary: REGRESSION(r282060) [GTK] API test /WebKit2Gtk/TestContextMenu /webkit/WebKit...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-08 05:46 PDT by Lauro Moura
Modified: 2022-11-22 08:24 PST (History)
1 user (show)

See Also:

Attachments
html for testing (1.16 KB, text/html)
2021-09-08 07:00 PDT, Lauro Moura 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-09-08 05:46:33 PDT 
/WebKit2Gtk/TestContextMenu /webkit/WebKitWebView/default-menu

Failure:

ERROR:../../Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:355:virtual bool ContextMenuDefaultTest::contextMenu(WebKitContextMenu*, GdkEvent*, WebKitHitTestResult*): 'webkit_hit_test_result_context_is_link(hitTestResult)' sh     ould be FALSE                                                             

Last good: 241359@main // 282059
First bad: 241364@main  // r282064
First GTK release build with error: https://build.webkit.org/#/builders/57/builds/3591

Commits in range:

r282064 2021-09-06 [GTK] The Xvfb display server may fail to start sometimes causing tests to randomly crash https://bugs.webkit.org/show_bug.cgi?id=229758
r282063 2021-09-06 REGRESSION (r280017): Calling getBoundingClientRect() on an empty element with "break-before: column" in columns returns a rect with all zeros https://bugs.webkit.org/show_bug.cgi?id=229747
r282062 2021-09-06 [GLIB] Garden tests related to the experimetal <attachment> element https://bugs.webkit.org/show_bug.cgi?id=229966
r282061 2021-09-06 Fix WebKitGTK build on MacOS https://bugs.webkit.org/show_bug.cgi?id=225850
r282060 2021-09-06 [LFC][Integration] Use inline boxes in run vector for hit testing https://bugs.webkit.org/show_bug.cgi?id=229933
Comment 1 Lauro Moura 2021-09-08 05:57:44 PDT 
Gardened in r282139/r282140 (typo in test path...)
Comment 2 Lauro Moura 2021-09-08 06:59:42 PDT 
Indeed introduced in r282060 from bug229933

With this revision, the hit region for the linked image in the test's html kinda "leaks" over the non-link image, causing the assertion to fail.
Comment 3 Lauro Moura 2021-09-08 07:00:41 PDT 
Created attachment 437624 [details]
html for testing
Comment 4 Lauro Moura 2022-11-22 04:00:27 PST 
Pull request: https://github.com/WebKit/WebKit/pull/6730
Comment 5 EWS 2022-11-22 04:19:03 PST 
Test gardening commit 256931@main (42969491cbfa): <https://commits.webkit.org/256931@main>

Reviewed commits have been landed. Closing PR #6730 and removing active labels.
Comment 6 Lauro Moura 2022-11-22 08:24:24 PST 
Closing as this test is passing since 254755@main and the flaky timeout will be tracked by bug248213