Bug 229933 - [LFC][Integration] Use inline boxes in run vector for hit testing
Summary: [LFC][Integration] Use inline boxes in run vector for hit testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-09-06 01:06 PDT by Antti Koivisto
Modified: 2021-09-08 06:59 PDT (History)
8 users (show)

See Also:


Attachments
wip (3.65 KB, patch)
2021-09-06 01:26 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (4.13 KB, patch)
2021-09-06 06:17 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-09-06 01:06:17 PDT
Simplify hit testing
Comment 1 Antti Koivisto 2021-09-06 01:26:05 PDT
Created attachment 437395 [details]
wip
Comment 2 Antti Koivisto 2021-09-06 06:17:02 PDT
Created attachment 437408 [details]
patch
Comment 3 zalan 2021-09-06 07:45:41 PDT
Comment on attachment 437408 [details]
patch

so much better!
Comment 4 EWS 2021-09-06 10:49:18 PDT
Committed r282060 (241360@main): <https://commits.webkit.org/241360@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 437408 [details].
Comment 5 Radar WebKit Bug Importer 2021-09-06 10:50:18 PDT
<rdar://problem/82796806>
Comment 6 Aakash Jain 2021-09-06 15:53:56 PDT
(In reply to EWS from comment #4)
> Committed r282060 (241360@main): <https://commits.webkit.org/241360@main>
This seems to have broken following api-gtk test (as also indicated by EWS): /WebKit2Gtk/TestContextMenu:/webkit/WebKitWebView/default-menu
Comment 7 zalan 2021-09-06 15:59:07 PDT
(In reply to Aakash Jain from comment #6)
> (In reply to EWS from comment #4)
> > Committed r282060 (241360@main): <https://commits.webkit.org/241360@main>
> This seems to have broken following api-gtk test (as also indicated by EWS):
> /WebKit2Gtk/TestContextMenu:/webkit/WebKitWebView/default-menu
this is sus.