Bug 229844 - FontFaceSet.check() needs to react to style changes
Summary: FontFaceSet.check() needs to react to style changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 229850 229911 229975
  Show dependency tree / graph
 
Reported: 2021-09-02 18:52 PDT by Myles C. Maxfield
Modified: 2021-09-08 14:03 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.58 KB, patch)
2021-09-02 19:03 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (5.57 KB, patch)
2021-09-02 19:15 PDT, Myles C. Maxfield 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-09-02 18:52:05 PDT 
FontFaceSet.check() needs to react to style changes
Comment 1 Myles C. Maxfield 2021-09-02 19:03:58 PDT 
Created attachment 437232 [details]
Patch
Comment 2 Myles C. Maxfield 2021-09-02 19:09:56 PDT 
Comment on attachment 437232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437232&action=review

> LayoutTests/fast/text/FontFaceSet-check-after-style-update.html:24
> +document.fonts.values().next().value.load();

This should be just "fonts.values().next().value.load()".
Comment 3 Myles C. Maxfield 2021-09-02 19:15:36 PDT 
Created attachment 437234 [details]
Patch
Comment 4 Sam Weinig 2021-09-03 09:46:37 PDT 
Comment on attachment 437234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=437234&action=review

Should we / can we have a font resource that never get's cached (e.g. sets the right headers) to avoid the need to invalidate?

> Source/WebCore/css/FontFaceSet.cpp:186
> +    auto protect = m_backing;

Like the other patch, I would change this to:

Ref protect = m_backing;

(assuming that compiles).
Comment 5 Myles C. Maxfield 2021-09-03 13:08:14 PDT 
Committed r282016 (241321@main): <https://commits.webkit.org/241321@main>
Comment 6 Radar WebKit Bug Importer 2021-09-03 13:09:19 PDT 
<rdar://problem/82735822>