By default, we should rebase pull-requests on the target branch whenever a user uploads them.
<rdar://problem/82451030>
Created attachment 436661 [details] Patch
pull-request: https://github.com/WebKit/WebKit/pull/5
Looks like your argument parser addition for rebase wouldn't work as expected/ is confusing. You're flags are `--no-rebase` and `--rebase` on the same argument that looks to be saying not to use rebase.
Created attachment 436807 [details] Patch
Created attachment 436882 [details] Patch
Comment on attachment 436882 [details] Patch r=me
Created attachment 436931 [details] Patch for landing
Committed r281821 (241155@main): <https://commits.webkit.org/241155@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 436931 [details].
Reopening to attach new patch.
Created attachment 437052 [details] Patch
Comment on attachment 437052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437052&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:775 > + commit = self.commit if self.is_svn else None Isn't it `self.commit()`?
Created attachment 437055 [details] Patch
Comment on attachment 437055 [details] Patch This is a regression from https://trac.webkit.org/changeset/281821/webkit, and the change looks good to me.
Committed r281871 (241201@main): <https://commits.webkit.org/241201@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 437055 [details].