Bug 229089 - [git-webkit] Add pull-request command
Summary: [git-webkit] Add pull-request command
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-08-13 11:26 PDT by Jonathan Bedard
Modified: 2021-08-27 13:02 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2021-08-13 13:50 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Part 1 (2.87 KB, patch)
2021-08-13 13:59 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Part 2 (5.59 KB, patch)
2021-08-13 14:03 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Part 3 (5.12 KB, patch)
2021-08-13 14:09 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Part 4 (1.42 KB, patch)
2021-08-13 14:16 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Part 5 (2.38 KB, patch)
2021-08-13 14:21 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Part 1 (2.88 KB, patch)
2021-08-19 16:38 PDT, Jonathan Bedard 		dewei_zhu: review+
Details | Formatted Diff | Diff
Part 2 (13.37 KB, patch)
2021-08-19 16:45 PDT, Jonathan Bedard 		dewei_zhu: review+
Details | Formatted Diff | Diff
Part 3 (11.99 KB, patch)
2021-08-19 16:55 PDT, Jonathan Bedard 		dewei_zhu: review+
Details | Formatted Diff | Diff
Part 4 (1.42 KB, patch)
2021-08-19 16:58 PDT, Jonathan Bedard 		dewei_zhu: review+
Details | Formatted Diff | Diff
Part 5 (7.47 KB, patch)
2021-08-19 17:08 PDT, Jonathan Bedard 		dewei_zhu: review+
Details | Formatted Diff | Diff
Part 1 (4.90 KB, patch)
2021-08-20 15:22 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Part 2 (14.70 KB, patch)
2021-08-20 16:07 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Part 3 (12.93 KB, patch)
2021-08-21 08:24 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Part 4 (2.76 KB, patch)
2021-08-22 07:51 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Part 5 (8.87 KB, patch)
2021-08-22 12:12 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Part 6 (45.79 KB, patch)
2021-08-23 17:01 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (47.73 KB, patch)
2021-08-24 08:20 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (47.70 KB, patch)
2021-08-27 07:45 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (18) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-08-13 11:26:51 PDT 
As WebKit moves to GitHub, the project needs to support pull-requests. This bug tracks the addition of a basic pull-request command which creates a branch on a user's fork of the project, and then link that branch to a new pull-request on GitHub.
Comment 1 Radar WebKit Bug Importer 2021-08-13 11:27:26 PDT 
<rdar://problem/81908751>
Comment 2 Jonathan Bedard 2021-08-13 13:26:44 PDT 
I will be uploading patches to this bug as well, but it seems appropriate that the change which adds support for pull-requests should itself be a pull request:
https://github.com/WebKit/WebKit/pull/4
Comment 3 Jonathan Bedard 2021-08-13 13:50:46 PDT 
Created attachment 435504 [details]
Patch
Comment 4 Jonathan Bedard 2021-08-13 13:59:22 PDT 
Created attachment 435505 [details]
Part 1
Comment 5 Jonathan Bedard 2021-08-13 14:03:37 PDT 
Created attachment 435507 [details]
Part 2
Comment 6 Jonathan Bedard 2021-08-13 14:09:21 PDT 
Created attachment 435508 [details]
Part 3
Comment 7 Jonathan Bedard 2021-08-13 14:16:49 PDT 
Created attachment 435510 [details]
Part 4
Comment 8 Jonathan Bedard 2021-08-13 14:21:18 PDT 
Created attachment 435513 [details]
Part 5
Comment 9 Jonathan Bedard 2021-08-19 16:38:32 PDT 
Created attachment 435914 [details]
Part 1
Comment 10 Jonathan Bedard 2021-08-19 16:45:54 PDT 
Created attachment 435917 [details]
Part 2
Comment 11 Jonathan Bedard 2021-08-19 16:55:15 PDT 
Created attachment 435921 [details]
Part 3
Comment 12 Jonathan Bedard 2021-08-19 16:58:16 PDT 
Created attachment 435922 [details]
Part 4
Comment 13 Jonathan Bedard 2021-08-19 17:08:49 PDT 
Created attachment 435927 [details]
Part 5
Comment 14 dewei_zhu 2021-08-20 14:36:22 PDT 
Comment on attachment 435927 [details]
Part 5

r=me
Comment 15 dewei_zhu 2021-08-20 14:40:10 PDT 
Comment on attachment 435914 [details]
Part 1

r=me
Comment 16 dewei_zhu 2021-08-20 14:40:29 PDT 
Comment on attachment 435917 [details]
Part 2

r=me
Comment 17 dewei_zhu 2021-08-20 14:41:41 PDT 
Comment on attachment 435921 [details]
Part 3

r=me
Comment 18 dewei_zhu 2021-08-20 14:41:54 PDT 
Comment on attachment 435922 [details]
Part 4

r=me
Comment 19 Jonathan Bedard 2021-08-20 15:22:30 PDT 
Created attachment 436036 [details]
Part 1
Comment 20 EWS 2021-08-20 15:52:26 PDT 
Committed r281346 (240762@main): <https://commits.webkit.org/240762@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436036 [details].
Comment 21 Jonathan Bedard 2021-08-20 16:07:04 PDT 
Reopening to attach new patch.
Comment 22 Jonathan Bedard 2021-08-20 16:07:05 PDT 
Created attachment 436040 [details]
Part 2
Comment 23 EWS 2021-08-20 18:01:54 PDT 
Found 1 new test failure: http/tests/media/modern-media-controls/pip-support/pip-support-live-broadcast.html
Comment 24 EWS 2021-08-20 22:25:14 PDT 
Committed r281363 (240778@main): <https://commits.webkit.org/240778@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436040 [details].
Comment 25 Jonathan Bedard 2021-08-21 08:24:56 PDT 
Reopening to attach new patch.
Comment 26 Jonathan Bedard 2021-08-21 08:24:57 PDT 
Created attachment 436074 [details]
Part 3
Comment 27 EWS 2021-08-21 12:20:03 PDT 
Committed r281379 (240794@main): <https://commits.webkit.org/240794@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436074 [details].
Comment 28 Jonathan Bedard 2021-08-22 07:51:05 PDT 
Reopening to attach new patch.
Comment 29 Jonathan Bedard 2021-08-22 07:51:07 PDT 
Created attachment 436116 [details]
Part 4
Comment 30 EWS 2021-08-22 09:29:37 PDT 
Committed r281399 (240807@main): <https://commits.webkit.org/240807@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436116 [details].
Comment 31 Jonathan Bedard 2021-08-22 12:12:13 PDT 
Reopening to attach new patch.
Comment 32 Jonathan Bedard 2021-08-22 12:12:14 PDT 
Created attachment 436122 [details]
Part 5
Comment 33 EWS 2021-08-22 13:11:53 PDT 
Committed r281412 (240808@main): <https://commits.webkit.org/240808@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436122 [details].
Comment 34 Jonathan Bedard 2021-08-23 17:01:57 PDT 
Reopening to attach new patch.
Comment 35 Jonathan Bedard 2021-08-23 17:01:58 PDT 
Created attachment 436250 [details]
Part 6
Comment 36 Jonathan Bedard 2021-08-24 08:20:58 PDT 
Created attachment 436288 [details]
Patch
Comment 37 dewei_zhu 2021-08-26 17:40:04 PDT 
Comment on attachment 436288 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=436288&action=review

r=me

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:203
> +                states = params.get('state', [])

params can be `None` right? Do we need `states = (params or {}).get('state', [])` ?

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/bitbucket.py:207
> +                at = params.get('at')

Ditto.
Comment 38 Jonathan Bedard 2021-08-27 07:45:26 PDT 
Created attachment 436623 [details]
Patch for landing
Comment 39 EWS 2021-08-27 08:16:34 PDT 
Committed r281695 (241045@main): <https://commits.webkit.org/241045@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436623 [details].