Bug 229602 - [css-position-sticky] createIndicatorForStickyElements testing function races with font loading
Summary: [css-position-sticky] createIndicatorForStickyElements testing function races...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords: InRadar
Depends on:
Blocks: 203450
  Show dependency tree / graph
 
Reported: 2021-08-27 01:03 PDT by Martin Robinson
Modified: 2021-08-27 09:51 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.86 KB, patch)
2021-08-27 01:06 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (5.64 KB, patch)
2021-08-27 01:09 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Patch (5.60 KB, patch)
2021-08-27 01:11 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2021-08-27 01:03:18 PDT 
The JavaScript function createIndicatorForStickyElements which is used by position: sticky tests measures the size of a div to make an idicator div. The size of the divs that it measures sometimes use web fonts though, so it's possible for the indicator div to be the wrong size if the function executes before web fonts have loaded.
Comment 1 Martin Robinson 2021-08-27 01:06:01 PDT 
Created attachment 436612 [details]
Patch
Comment 2 EWS Watchlist 2021-08-27 01:07:38 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Martin Robinson 2021-08-27 01:09:52 PDT 
Created attachment 436613 [details]
Patch
Comment 4 Martin Robinson 2021-08-27 01:11:30 PDT 
Created attachment 436614 [details]
Patch
Comment 5 Martin Robinson 2021-08-27 01:36:27 PDT 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/30211
Comment 6 Martin Robinson 2021-08-27 09:47:05 PDT 
Comment on attachment 436614 [details]
Patch

Thanks for the review!
Comment 7 EWS 2021-08-27 09:50:53 PDT 
Committed r281698 (241048@main): <https://commits.webkit.org/241048@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 436614 [details].
Comment 8 Radar WebKit Bug Importer 2021-08-27 09:51:44 PDT 
<rdar://problem/82442988>