Bug 229082 – Unprefix -webkit-mask and longhand forms

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Sam Sneddon [:gsnedders]]

For some of these the value keywords have changed (e.g. from margin to margin-box), and notably Chrome doesn't yet support it prefixed.  Nevertheless, Firefox does support the unprefixed form and there are a (small) number of WPT tests that rely on this.

[Radar WebKit Bug Importer]

<rdar://problem/82176660>

[Simon Fraser (smfr)]

I have a patch for part of this.

[Simon Fraser (smfr)]

Created attachment 444576 [details]
Work in progress patch

[Matt Woodrow]

Created attachment 445116 [details]
Patch

[Matt Woodrow]

Created attachment 445152 [details]
Patch

[Matt Woodrow]

Created attachment 445161 [details]
Patch

[Matt Woodrow]

Created attachment 445242 [details]
Patch

[Antti Koivisto]

Comment on attachment 445242 [details]
Patch

looks like you need to do some more rebasing

[Antti Koivisto]

Comment on attachment 445242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445242&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:4458
> +size_t ComputedStyleExtractor::getLayerCount(CSSPropertyID property)
> +{
> +    ASSERT(property == CSSPropertyBackground || property == CSSPropertyMask);
> +    if (!styledElement())
> +        return 0;

I already see this code in trunk so I suppose it is not really part of this change?

We don't start function names with 'get', this should be called layerCount/countLayers/countLayersForProperty or similar. There are functions in this file that don't follow the rule, that's not a reason to add new code like that. Also some of them are like that because they are exposed in CSSOM.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:4476
> +Ref<CSSValueList> ComputedStyleExtractor::getFillLayerPropertyShorthandValue(CSSPropertyID property, const StylePropertyShorthand& propertiesBeforeSlashSeparator, const StylePropertyShorthand& propertiesAfterSlashSeparator, CSSPropertyID lastLayerProperty)
> +{
> +    ASSERT(property == CSSPropertyBackground || property == CSSPropertyMask);
> +    size_t layerCount = getLayerCount(property);

This too

[Matt Woodrow]

Created attachment 446401 [details]
Patch

[Matt Woodrow]

Created attachment 446485 [details]
Patch

[EWS]

Committed r286795 (245035@main): <https://commits.webkit.org/245035@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 446485 [details].

[Brent Fulgham]

*** Bug 121432 has been marked as a duplicate of this bug. ***

[Tim Nguyen (:ntim)]

*** Bug 137294 has been marked as a duplicate of this bug. ***

[Tim Nguyen (:ntim)]

*** Bug 137292 has been marked as a duplicate of this bug. ***