Bug 229041 – Add Cross-Origin-Embedder-Policy support for Blob URLs

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Chris Dumez]

Add Cross-Origin-Embedder-Policy support for Blob URLs.

[Chris Dumez]

Created attachment 435430 [details]
WIP patch

[Chris Dumez]

imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https.html is completely failing still, even though html/cross-origin-opener-policy/coep-blob-popup.https.html is fully passing :/ Investigating...

[Chris Dumez]

Created attachment 435521 [details]
Patch

[Alex Christensen]

Comment on attachment 435521 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435521&action=review

> Source/WebKitLegacy/win/WebCoreSupport/WebPlatformStrategies.cpp:84
> +    void registerBlobURL(const URL& url, const URL& srcURL, const CrossOriginOpenerPolicy& coop, const CrossOriginEmbedderPolicy& coep) final { m_blobRegistry.registerBlobURL(url, srcURL, coop, coep); }

Should we make a struct that contains both and call it CrossOriginPolicies?

> LayoutTests/platform/mac-wk1/TestExpectations:376
> +imported/w3c/web-platform-tests/html/cross-origin-opener-policy/coep-blob-popup.https.html [ Skip ]

Why not skip the whole directory?

> LayoutTests/platform/win/TestExpectations:3728
> +imported/w3c/web-platform-tests/html/cross-origin-opener-policy/coep-blob-popup.https.html [ Skip ]

ditto

[Chris Dumez]

(In reply to Alex Christensen from comment #4)
> Comment on attachment 435521 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=435521&action=review
> 
> > Source/WebKitLegacy/win/WebCoreSupport/WebPlatformStrategies.cpp:84
> > +    void registerBlobURL(const URL& url, const URL& srcURL, const CrossOriginOpenerPolicy& coop, const CrossOriginEmbedderPolicy& coep) final { m_blobRegistry.registerBlobURL(url, srcURL, coop, coep); }
> 
> Should we make a struct that contains both and call it CrossOriginPolicies?

Sure, why not.

> 
> > LayoutTests/platform/mac-wk1/TestExpectations:376
> > +imported/w3c/web-platform-tests/html/cross-origin-opener-policy/coep-blob-popup.https.html [ Skip ]
> 
> Why not skip the whole directory?
> 
> > LayoutTests/platform/win/TestExpectations:3728
> > +imported/w3c/web-platform-tests/html/cross-origin-opener-policy/coep-blob-popup.https.html [ Skip ]
> 
> ditto

I guess we could. I don't really care about COOP for WK1. That said, COOP is implemented and working in WebKit1. The only reason this test fails on WK1 is because the test relies on COEP in addition to COOP (and COEP is unimplemented in WK1).

[Chris Dumez]

Created attachment 435529 [details]
Patch

[Darin Adler]

Comment on attachment 435529 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=435529&action=review

> Source/WebCore/dom/SecurityContext.h:30
> +#include "PolicyContainer.h"

Typically we don’t need to include a header just to declare a function with that type as a return value. It can be a forward declaration.

[Chris Dumez]

Created attachment 435530 [details]
Patch

[EWS]

Committed r281055 (240518@main): <https://commits.webkit.org/240518@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435530 [details].

[Radar WebKit Bug Importer]

<rdar://problem/81925692>