Bug 228951 - Cherry-pick ANGLE: Revise WebGL's shaderSource validation
Summary: Cherry-pick ANGLE: Revise WebGL's shaderSource validation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 223315
  Show dependency tree / graph
 
Reported: 2021-08-10 06:06 PDT by Kimmo Kinnunen
Modified: 2021-08-12 14:09 PDT (History)
6 users (show)

See Also:

Attachments
Patch (12.35 KB, patch)
2021-08-10 06:12 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (12.84 KB, patch)
2021-08-10 06:52 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (12.61 KB, patch)
2021-08-10 11:57 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch for landing (12.66 KB, patch)
2021-08-10 22:45 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-08-10 06:06:11 PDT 
Cherry-pick ANGLE: Revise WebGL's shaderSource validation
Comment 1 Kimmo Kinnunen 2021-08-10 06:12:03 PDT 
Created attachment 435251 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-08-10 06:52:36 PDT 
Created attachment 435254 [details]
Patch
Comment 3 Kimmo Kinnunen 2021-08-10 11:57:11 PDT 
Created attachment 435278 [details]
Patch
Comment 4 EWS Watchlist 2021-08-10 11:58:06 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 5 Kenneth Russell 2021-08-10 13:00:41 PDT 
Comment on attachment 435278 [details]
Patch

Looks good; verified that WebGLRenderingContextBase is just passing through these shader sources to ANGLE rather than doing any processing like it used to. r+
Comment 6 Kimmo Kinnunen 2021-08-10 22:45:37 PDT 
Created attachment 435324 [details]
Patch for landing
Comment 7 EWS 2021-08-11 04:21:01 PDT 
Committed r280904 (240428@main): <https://commits.webkit.org/240428@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435324 [details].
Comment 8 Radar WebKit Bug Importer 2021-08-11 04:21:29 PDT 
<rdar://problem/81787531>